The mmap stuff definitely needs more eyes!

Philip Van Hoof <[email protected]>
Newsgroups gmane.comp.gnome.evolution.devel
Message-ID <[email protected]>
Eeeek. Look at what I just found in my own patches!!

static CamelMessageInfo *
message_info_load (CamelFolderSummary *s, FILE *in)
{
	CamelMessageInfo *info;
	CamelImapMessageInfo *iinfo;

	info = camel_imap_summary_parent->message_info_load (s, in);

	if (info) {
		unsigned char* ptrchr = s->filepos;
		ptrchr = camel_file_util_mmap_decode_uint32 (ptrchr, &iinfo->server_flags, FALSE);
		s->filepos = ptrchr;
		label_to_flags(iinfo);
	}

	return info;
}


The "iinfo" is simply never assigned, yet being used! Eeeeeeek! *scared
by my own mistakes now*. Very strange that didn't crash and burn on x86
but does crash on ARM.


-- 
Philip Van Hoof, software developer at x-tend 
home: me at pvanhoof dot be 
gnome: pvanhoof at gnome dot org 
work: vanhoof at x-tend dot be 
http://www.pvanhoof.be - http://www.x-tend.be
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.