calendar a11y fix for 331550

Harry Lu <[email protected]>
Newsgroups gmane.comp.gnome.evolution.patches
Message-ID <1141121768.12128.22.camel@silvermedal>
Hi,
	Attached is the fix for :
http://bugzilla.gnome.org/show_bug.cgi?id=331550

	Please review it.
	Thanks!
		Harry

_______________________________________________
Evolution-patches mailing list
[email protected]
http://mail.gnome.org/mailman/listinfo/evolution-patches
calcrash.diff (text/x-patch, 1.9 KB)
Index: ChangeLog
===================================================================
RCS file: /cvs/gnome/evolution/a11y/ChangeLog,v
retrieving revision 1.47
diff -u -r1.47 ChangeLog
--- ChangeLog	27 Jan 2006 14:50:37 -0000	1.47
+++ ChangeLog	27 Feb 2006 13:01:57 -0000
@@ -1,3 +1,11 @@
+2006-02-27  Harry Lu <[email protected]>
+
+	Fix for 331550.
+
+	* calendar/ea-day-view.c: (ea_day_view_get_name): check the visibility of gcal
+	before trying to get label.
+	* calendar/ea-week-view.c: (ea_week_view_get_name): ditto.
+
 2006-01-27  Kjartan Maraas  <[email protected]>
 
 	reviewed by: Harish Krishnaswamy <[email protected]> 
Index: calendar/ea-day-view.c
===================================================================
RCS file: /cvs/gnome/evolution/a11y/calendar/ea-day-view.c,v
retrieving revision 1.9
diff -u -r1.9 ea-day-view.c
--- calendar/ea-day-view.c	2 Feb 2005 02:10:09 -0000	1.9
+++ calendar/ea-day-view.c	27 Feb 2006 13:01:57 -0000
@@ -137,6 +137,9 @@
 
 	day_view = E_DAY_VIEW (GTK_ACCESSIBLE (accessible)->widget);
 	gcal = e_calendar_view_get_calendar (E_CALENDAR_VIEW (day_view));
+	if (!GTK_WIDGET_VISIBLE (GTK_WIDGET (gcal)))
+		return NULL;
+
 	label_text = ea_gnome_calendar_get_label_description (gcal);
 
 	n_events = atk_object_get_n_accessible_children (accessible);
Index: calendar/ea-week-view.c
===================================================================
RCS file: /cvs/gnome/evolution/a11y/calendar/ea-week-view.c,v
retrieving revision 1.13
diff -u -r1.13 ea-week-view.c
--- calendar/ea-week-view.c	17 Jun 2005 15:20:23 -0000	1.13
+++ calendar/ea-week-view.c	27 Feb 2006 13:01:57 -0000
@@ -139,6 +139,9 @@
 
 	week_view = E_WEEK_VIEW (GTK_ACCESSIBLE (accessible)->widget);
 	gcal = e_calendar_view_get_calendar (E_CALENDAR_VIEW (week_view));
+	if (!GTK_WIDGET_VISIBLE (GTK_WIDGET (gcal)))
+		return NULL;
+
 	label_text = ea_gnome_calendar_get_label_description (gcal);
 
 	n_events = atk_object_get_n_accessible_children (accessible);
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.