Re: [Tasks] Updated patch for Bug #324560

Committed to the CVS HEAD!
-Simon

On Fri, 2006-03-03 at 18:39 +0530, pchenthill wrote:
> Looks good to commit.
> 
> thanks, Chenthill.
> 
> On Fri, 2006-03-03 at 15:09 +0800, sam yang wrote: 
> > Hi, Chenthill and all 
> > 
> > pls review the new patch. 
> > 
> > thanks.
> > -Sam
> > 
> > On Thu, 2006-03-02 at 22:24 +0530, pchenthill wrote:
> > > On Mon, 2006-02-27 at 12:02 +0800, sam yang wrote:
> > > >        /* Private data */
> > > >         ETasksPrivate *priv;
> > > > +
> > > > +       /* if we're active, this will be set */
> > > > +       BonoboUIComponent *uic;
> > > > }; 
> > > 
> > > It could be put inside the Private structure as its used only by
> > > ETasks and might not be needed outside.
> > As I thought before, the reason to put uic inside ETasks other than its
> > private structure, ETasksPrivate, is uic is evaluated in
> > tasks_control_activate() in tasks-control.c, where ETasksPrivate isn't
> > avaible.
> > 
> > When I planed to put uic inside ETasksPrivate and provide a function to
> > set its value, as you have suggested, I found we needn't to add a new
> > BonoboUIComponent at all, because we have had one: E_SEARCH_BAR
> > (ETasks->priv->search_bar)->ui_component. It is set in
> > tasks_control_activate() through  e_tasks_set_ui_component(). And it's
> > exactly the UI component which I want to get.
> > > 
> > > 
> > > thanks, Chenthill.
> _______________________________________________
> Evolution-patches mailing list
> [email protected]
> http://mail.gnome.org/mailman/listinfo/evolution-patches