Re: [Mail]Fix for bug 333243
Jeffrey Stedfast <[email protected]>
| Newsgroups | gmane.comp.gnome.evolution.patches |
|---|---|
| Organization | Novell, Inc. |
| Message-ID | <[email protected]> |
No, because if the patch is committed now, the real reason for the bug won't be tracked down and will go unresolved for years. Jeff On Fri, 2006-03-03 at 23:20 +0800, jeff wrote: > Yes, you are right. > But I think this is a very serious bug, because if it is not fixed, > new user will not be able to use evolution. So I suggest to commit it first. > Do you think so? > > Jeff Cai. > ----- Original Message ----- > From: "Jeffrey Stedfast" <[email protected]> > To: "jeff cai" <[email protected]> > Cc: <[email protected]> > Sent: Friday, March 03, 2006 11:05 PM > Subject: Re: [evolution-patches] [Mail]Fix for bug 333243 > > > >I think the more important question is how is this API getting a NULL > > uri? > > > > your fix may be correct, but it's still important to know WHY it is > > sometimes NULL first to be sure we aren't just fixing a symptom rather > > than the real bug. > > > > Jeff > > > > On Fri, 2006-03-03 at 21:23 +0800, jeff cai wrote: > >> Hi > >> If uri is null, don't remove it. > >> > >> Please review it. > >> > >> > >> _______________________________________________ > >> Evolution-patches mailing list > >> [email protected] > >> http://mail.gnome.org/mailman/listinfo/evolution-patches > > -- > > Jeffrey Stedfast > > Evolution Hacker - Novell, Inc. > > [email protected] - www.novell.com > > > > _______________________________________________ > > Evolution-patches mailing list > > [email protected] > > http://mail.gnome.org/mailman/listinfo/evolution-patches > > > -- Jeffrey Stedfast Evolution Hacker - Novell, Inc. [email protected] - www.novell.com