Re: [evolution-data-server] Fix for bug #331633

According to Veerapuram's approval, committed the patch to CVS HEAD.

-Simon

On Mon, 2006-03-06 at 18:03 +0800, Irene Huang wrote:
> Hi, 
> 
> Modified as per Jeff's suggestion :) 
> 
> Please review :) 
> 
> thanks 
> 
> --Irene
> On Tue, 2006-02-21 at 11:34 -0500, Jeffrey Stedfast wrote:
> > On Mon, 2006-02-20 at 02:40 -0700, Veerapuram Varadhan wrote:
> > > On Sat, 2006-02-18 at 04:48 +0000, Irene Huang  wrote:
> > > > +       if (strlen(dn_value->str))
> > > > +               dn = g_strndup (dn_value->str, strlen(dn_value->str) -
> > > > 1);
> > > 
> > > Wouldn't it be better to store strlen() in a variable, instead of
> > > calling strlen twice?
> > 
> > another idea is simply doing:
> > 
> > if (dn_value->str[0])
> > 
> > no need to strlen it.
> > 
> > > 
> > > Thanks,
> > > 
> > > V. Varadhan
> > > _______________________________________________
> > > Evolution-patches mailing list
> > > [email protected]
> > > http://mail.gnome.org/mailman/listinfo/evolution-patches
> > > 
> _______________________________________________
> Evolution-patches mailing list
> [email protected]
> http://mail.gnome.org/mailman/listinfo/evolution-patches