fix for calendar crash 333693

Harry Lu <[email protected]>
Newsgroups gmane.comp.gnome.evolution.patches
Message-ID <1141708119.15484.17.camel@silvermedal>
Hi,
	Please review the attached patch for :
http://bugzilla.gnome.org/show_bug.cgi?id=333693

	Thanks!
		harry

_______________________________________________
Evolution-patches mailing list
[email protected]
http://mail.gnome.org/mailman/listinfo/evolution-patches
crash333693.diff (text/x-patch, 1.2 KB)
Index: ChangeLog
===================================================================
RCS file: /cvs/gnome/evolution/calendar/ChangeLog,v
retrieving revision 1.3011
diff -u -r1.3011 ChangeLog
--- ChangeLog	6 Mar 2006 15:58:53 -0000	1.3011
+++ ChangeLog	7 Mar 2006 04:59:22 -0000
@@ -1,3 +1,9 @@
+2006-03-07  Harry Lu  <[email protected]>
+
+	Fix for 333693.
+	* gui/calendar-component.c: (update_task_selection): need to see if 
+	source is NULL to avoid a CRITICAL warning.
+
 2006-03-06  Veerapuram Varadhan  <[email protected]>
 
 	**Fixes #321832
Index: gui/calendar-component.c
===================================================================
RCS file: /cvs/gnome/evolution/calendar/gui/calendar-component.c,v
retrieving revision 1.214
diff -u -r1.214 calendar-component.c
--- gui/calendar-component.c	16 Jan 2006 15:57:02 -0000	1.214
+++ gui/calendar-component.c	7 Mar 2006 04:59:22 -0000
@@ -416,7 +416,7 @@
 		ESource *source;
 
 		source = e_source_list_peek_source_by_uid (component_view->task_source_list, uid);
-		if (!gnome_calendar_add_source (component_view->calendar, E_CAL_SOURCE_TYPE_TODO, source))
+		if (source && !gnome_calendar_add_source (component_view->calendar, E_CAL_SOURCE_TYPE_TODO, source))
 			/* FIXME do something */;
 	}
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.