Re: const fix for camel-charset-map.c's autogenerated camel-charset-map-private.h
Parthasarathi Susarla <[email protected]>
| Newsgroups | gmane.comp.gnome.evolution.patches |
|---|---|
| Organization | Novell Software Development (I) Ltd. |
| Message-ID | <[email protected]> |
Wonder how it changed. Probably the iconv patch from simonz(??)
Thanks for the patch
CHeers,
partha
On Tue, 2006-04-04 at 11:16 -0400, Jeffrey Stedfast wrote:
> This patch fixes Ross Burton's previous const fixes to the charset map
> tables by doing it the right way :)
>
> I did, however, notice that the resulting table data is now different
> after re-generating the table:
>
> --- camel-charset-map-private.h 2005-08-23 22:35:14.000000000 -0400
> +++ foo.h 2006-04-04 11:13:57.000000000 -0400
> @@ -16,7 +16,7 @@
> 0xbf, 0xbf, 0xbf, 0xbf, 0xbf, 0xbf, 0xbf, 0xbf,
> 0xbf, 0xbf, 0xbf, 0xbf, 0xbf, 0xbf, 0xbf, 0xbf,
> 0xbf, 0xbf, 0xbf, 0xbf, 0xbf, 0xbf, 0xbf, 0xbf,
> - 0xbf, 0xbf, 0x9f, 0x9f, 0x9f, 0x9f, 0x9f, 0x9f,
> + 0xbf, 0xbf, 0xbf, 0xbf, 0xbf, 0x9f, 0x9f, 0x9f,
> 0xf3, 0xf3, 0xf3, 0xf3, 0xf3, 0xf3, 0xf3, 0xf3,
> 0xf3, 0xf3, 0xf3, 0xf3, 0xf3, 0xf3, 0xf3, 0xf3,
> 0xf3, 0xf3, 0xf3, 0xf3, 0xf3, 0xf3, 0xf3, 0xf3,
> @@ -191,7 +191,7 @@
> 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> - 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> + 0x00, 0x00, 0x20, 0x00, 0x00, 0x00, 0x00, 0x00,
> 0x00, 0x00, 0x00, 0x00, 0x20, 0x20, 0x20, 0x00,
> 0x20, 0x20, 0x20, 0x00, 0x20, 0x00, 0x20, 0x20,
> 0x20, 0x20, 0x20, 0x20, 0x20, 0x20, 0x20, 0x20,
> @@ -337,7 +337,7 @@
> 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> - 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> + 0x00, 0x00, 0x00, 0x00, 0x20, 0x00, 0x00, 0x20,
> 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> @@ -560,7 +560,7 @@
> 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> };
>
> -struct {
> +static const struct {
> const unsigned char *bits0;
> const unsigned char *bits1;
> } camel_charmap[256] = {
> @@ -598,7 +598,7 @@
> { 0, 0, }, { 0, 0, }, { 0, 0, }, { 0, 0, }, { 0, 0, }, { 0, 0, }, { 0, 0, }, { 0, 0, },
> };
>
> -struct {
> +static const struct {
> const char *name;
> unsigned int bit;
> } camel_charinfo[] = {
>
>
>
> kinda worrying that the table data changed, but looking over the
> vc-annotate for camel-charset-map.c and camel-charset-map-private.h, I
> can't find what could have caused this difference :\
>
> perhaps the iconv data changed?
>
> _______________________________________________
> Evolution-patches mailing list
> [email protected]
> http://mail.gnome.org/mailman/listinfo/evolution-patches