Re: [Nld-patches] evolution-exchange patch for bug #179545 (b.g.o bug #344196)

On Fri, 2006-06-23 at 10:36 -0400, Robert Love wrote:
> > -               if ((n = camel_read (marshal->fd, buf + nread, len - nread)) > 0)
> > -                       nread += n;
> > -       } while (n && nread < len && errno != EINTR);
> > +               if ((n = camel_read (marshal->fd, buf + nread, len - nread)) <= 0)
> > +                       break;
> > +               nread += n;
> > +       } while (nread < len);
> 
> You don't want to handle EINTR any longer?

camel_read() emits EINTR *only* when the operation was cancelled (it's
not a system-level EINTR - and probably a poorly chosen errno, but oh
well...)

so if camel_read() returns -1, it's not recoverable...

Jeff

> 
> 	Robert Love
> 
> 
-- 
Jeffrey Stedfast
Evolution Hacker - Novell, Inc.
[email protected]  - www.novell.com