Re: [Nld-patches] evolution-exchange patch for bug #179545 (b.g.o bug #344196)
Jeffrey Stedfast <[email protected]>
| Newsgroups | gmane.comp.gnome.evolution.patches |
|---|---|
| Organization | Novell, Inc. |
| Message-ID | <[email protected]> |
EINTR isn't the same for camel_read() as read() :) EINTR only happens when the CamelOperation for the thread is cancelled, which means the socket needs to be disconnected. On Fri, 2006-06-23 at 15:01 -0500, Hans Petter Jansson wrote: > diff -up dude :) > > Your patch makes it close the socket if it gets EINTR. This could be a > problem if you're transferring actual data and it's not just a wakeup > pipe. That part may have been bad even before your patch, since it > checks for errno != EINTR even when the read call is successful (the > value of errno is really only defined if the call fails). > > Is it your intent to not handle EINTR here? > -- Jeffrey Stedfast Evolution Hacker - Novell, Inc. [email protected] - www.novell.com