Re: [Nld-patches] evolution-exchange patch for bug #179545 (b.g.o bug #344196)

Hans Petter Jansson <[email protected]> Fri, 23 Jun 2006 15:01:59 -0500

Newsgroups	gmane.comp.gnome.evolution.patches
Organization	Novell, Inc.
Message-ID	<[email protected]>

diff -up dude :)

Your patch makes it close the socket if it gets EINTR. This could be a
problem if you're transferring actual data and it's not just a wakeup
pipe. That part may have been bad even before your patch, since it
checks for errno != EINTR even when the read call is successful (the
value of errno is really only defined if the call fails).

Is it your intent to not handle EINTR here?

-- 
Hans Petter