Re: Memory improvement for the tokens in camel_folder_summary.c

"Veerapuram Varadhan" <[email protected]>
Newsgroups gmane.comp.gnome.evolution.patches
Message-ID <[email protected]>
On Wed, 2006-07-26 at 12:35 +0000, Philip Van Hoof wrote:
> +
> +guint bytes;
Whats this for?  Didn't you get a warning of "unused variable"?

> +
> +       for (i=0; i<tokens_len; i++)
> +               if (!strcmp (str, tokens[i]))
> +               {
should be...
                  if (!strcmp(str, tokens[i])) {

No need to resend another patch.  I will take it in this time, however,
do take care of coding style in your future patches.

V. Varadhan


 Novell, Inc. 
Software for the Open Enterprise™
http://www.novell.com
_______________________________________________
Evolution-patches mailing list
[email protected]
http://mail.gnome.org/mailman/listinfo/evolution-patches
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.