Leak in the shell

Kjartan Maraas <[email protected]>
Newsgroups gmane.comp.gnome.evolution.patches
Message-ID <1155737454.28210.20.camel@rivendell>
More gconf_client_get_string() leakage.

Cheers
Kjartan

_______________________________________________
Evolution-patches mailing list
[email protected]
http://mail.gnome.org/mailman/listinfo/evolution-patches
evolution-shell-leak.patch (text/x-patch, 870 B)
? shell.error
Index: e-user-creatable-items-handler.c
===================================================================
RCS file: /cvs/gnome/evolution/shell/e-user-creatable-items-handler.c,v
retrieving revision 1.18
diff -u -p -r1.18 e-user-creatable-items-handler.c
--- e-user-creatable-items-handler.c	13 Jul 2006 18:16:54 -0000	1.18
+++ e-user-creatable-items-handler.c	16 Aug 2006 14:10:35 -0000
@@ -709,6 +709,7 @@ new_button_change (GConfClient *gconf,
 	set_combo_button_style (E_COMBO_BUTTON (priv->new_button), 
 				val, priv->default_menu_item->icon);	
 
+	g_free (val);
 	gtk_widget_show (priv->new_button);
 }
 
@@ -756,6 +757,7 @@ setup_toolbar_button (EUserCreatableItem
 	gtk_object_sink (GTK_OBJECT (priv->tooltips));
 	gtk_tooltips_set_tip (priv->tooltips, priv->new_button,
 			      priv->default_menu_item->tooltip, NULL);
+	g_free (val);
 }
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.