Re: Warning fixes

On Tue, 2006-10-17 at 09:58 +0200, Philip Van Hoof wrote:

> Hi there Kjartan and Pavel,
> 
> I'm doing compilation warning fixes in eds/libedataserver (limited to
> the files that I need for compiling Camel, and I've sent all of those
> warning fixes to this mailing list a few seconds ago already) and in
> eds/camel Feel free to assist me with this, but please do tell me which
> files (in that case) you have handled and/or are planning to handle.
> 
> Else our patches will indeed overlap.

I'm not planning to do any more work on Evolution.  As far as I know, my
patches haven't been accepted.  Perhaps my karma is not positive enough.
In this case, you should probably do everything from scratch, since my
patch is not likely to overlap with anything.

Just one suggestion.  You may discover that there are too many warnings
to deal with all of them at once.  So you could split patches by the
topic.  for instance, one patch could deal with "()" in places where
"(void)" should be.  Next patch for all other prototype problems. One
more to deal with the warnings seen on 32-bit systems.  Then one or two
to deal with the warnings that only 64-bit systems exhibit.  Then a
patch for problems found by Valgrind on 32-bit systems.  Then the same
for the 64-bit systems.

-- 
Regards,
Pavel Roskin