Re: CamelObject with gslice

Philip Van Hoof <[email protected]> Wed, 18 Oct 2006 18:01:35 +0200
Newsgroups gmane.comp.gnome.evolution.patches
Message-ID <[email protected]>
On Wed, 2006-10-18 at 17:59 +0200, Philip Van Hoof wrote:
> On Wed, 2006-10-18 at 08:56 -0400, Matthew Barnes wrote:
> > On Wed, 2006-10-18 at 14:06 +0200, Philip Van Hoof wrote: 

> A small but very significant bugfix, Matthew. Strange that this has
> worked for me ... (any first camel_object_unref destroyed the alloc, not
> just the one when ref_count was 1).
> 
> I'll investigate whether I indeed need to check ref_count before freeing
> the gslice's alloc. But if not, something is at least strange.

Oh, found it. It doesn't matter. 

At that location ref_count is always <= 0. The if isn't needed, both
patches are okay.


-- 
Philip Van Hoof, software developer
home: me at pvanhoof dot be
gnome: pvanhoof at gnome dot org
work: vanhoof at x-tend dot be
blog: http://pvanhoof.be/blog