Re: One big patch to rule them all (compilation warnings in camel)

On Thu, 2006-10-19 at 12:13 +0200, Philip Van Hoof wrote:
> Folks, 
> 
> To show my intentions are good, because a lot people seem to actually
> question that, I will create a patch that contains all compilation
> warning fixes for Camel.
> 
> Well, not immediately all of them because some of my work isn't easy to
> extract a patch for (because I have a few significant other changes in
> my copy too).
> 
> I will post this as a enhancement on the bugzilla, here, will put
> Matthew in CC add a ChangeLog, I'll make sure it's tested and feature
> complete (it'll be one big patch).
> 
> I will also fix the problems Jeffrey raised. About the coding style. In
> fact, that is already done (using this script which I ran over the
> existing diffs):
> 
> while (<STDIN>)
> {
>         s/(\*\))([^\s])/$1 $2/g;
>         s/char\*/char \*/g;
>         s/guchar/unsigned gchar/g;
>         s/guint32/unsigned gint32/g;

... what are these last 2? should be "unsigned char" not "unsigned
gchar"

don't bother changing guint32, that's fine.

I just hate the gint/gchar stuff.

>         print;
> }
> 
> Hold on tight, it's coming to a mailing list and bugzilla near you.
> 
> 
-- 
Jeffrey Stedfast
Desktop Hacker - Novell, Inc.
[email protected]  - www.novell.com