Re: e_iconv_* replaced with g_iconv_*
Jeffrey Stedfast <[email protected]> Mon, 13 Nov 2006 11:25:16 -0500
| Newsgroups | gmane.comp.gnome.evolution.patches |
|---|---|
| Message-ID | <[email protected]> |
GIconv is not good enough for Evolution - we tried this before and it didn't work and caused all sorts of charset conversion problems. On Mon, 2006-11-13 at 17:19 +0100, Philip Van Hoof wrote: > On Mon, 2006-11-13 at 17:08 +0100, Philip Van Hoof wrote: > > > This patch replaces the e_iconv_open, e_iconv, e_iconv_close usage in > > Camel with the g_iconv_open, g_iconv and g_iconv_close APIs > > It looks like I can also remove the iconv_cache hashtable (or > re-implement the cache using GIConv? Maybe it's interesting to have a > cache like this, it feels like overkill to me, oh well) > > Hmm, I'll take a look at the hashtable this evening. > > The ideal situation is that I can remove this iconv detector in the > configure script (as it makes cross compilation a lot more difficult if > I have to compile something just to let it generate some include file) > and if that I can reuse existing functionality from glib (like GIConv). > > > This is a tracker bug for upstream Camel: > > http://bugzilla.gnome.org/show_bug.cgi?id=374734 > > > > Tinymail mailing list: this patch will probably soon go in the SVN repo. > > I will first do a few basic regression tests this evening. > -- Jeffrey Stedfast Desktop Hacker - Novell, Inc. [email protected] - www.novell.com