bug 543544 proposed patch against mark-all-read plugin

HggdH <[email protected]> Mon, 09 Jul 2007 11:36:20 -0500
Newsgroups gmane.comp.gnome.evolution.patches
Message-ID <1183998980.12394.9.camel@xango> 
From bug comments:


I have changed the text in the "mark as read"dialog to a more correct text
(mark on current folder only, on current folder and subfolders) as opposed to
the original (do not mark as read, mark as read).

I also took out the check on vfolder when navigating thru the folder list: this
test is not performed on current-folder operations only. 

**I do *not* know if this is correct or not (taking out the vfolder test)**. I
would really appreciate feedback on this.

Regards,

_______________________________________________
Evolution-patches mailing list
[email protected]
http://mail.gnome.org/mailman/listinfo/evolution-patches
bugzilla-453544.patch (text/x-patch, 1.8 KB) 
diff -ur -x '\.svn' evolution-trunk/mail/mail.error.xml evolution-trunk-new/mail/mail.error.xml
--- evolution-trunk/mail/mail.error.xml	2007-07-06 18:23:57.000000000 -0500
+++ evolution-trunk-new/mail/mail.error.xml	2007-07-09 07:28:35.000000000 -0500
@@ -362,10 +362,10 @@
 
   <error id="ask-mark-read" type="question" default="GTK_RESPONSE_NO">
     <_title>Mark all messages as read</_title>
-    <_primary>Mark all messages in subfolders as read?</_primary>
-    <_secondary xml:space="preserve">Do you want the operation to be performed in the subfolders?</_secondary>
-    <button stock="gtk-no" _label="_Do not Mark as Read" response="GTK_RESPONSE_NO"/>
-    <button stock="gtk-yes" _label="Mark as _Read" response="GTK_RESPONSE_YES"/>
+    <_primary>Mark all messages in this folder and subfolders as read?</_primary>
+    <_secondary xml:space="preserve">Do you want the operation to be performed also in the subfolders?</_secondary>
+    <button stock="gtk-no" _label="Only on _Current Folder" response="GTK_RESPONSE_NO"/>
+    <button stock="gtk-yes" _label="on Current Folder and _Subfolders" response="GTK_RESPONSE_YES"/>
   </error>
 
   <error id="ask-quick-offline" type="question" default="GTK_RESPONSE_NO">
diff -ur -x '\.svn' evolution-trunk/plugins/mark-all-read/mark-all-read.c evolution-trunk-new/plugins/mark-all-read/mark-all-read.c
--- evolution-trunk/plugins/mark-all-read/mark-all-read.c	2007-07-06 18:23:52.000000000 -0500
+++ evolution-trunk-new/plugins/mark-all-read/mark-all-read.c	2007-07-09 07:33:08.000000000 -0500
@@ -114,9 +114,7 @@
 		if (!(folder = camel_store_get_folder (store, fi->full_name, 0, ex)))
 			return;
 		
-		if (!CAMEL_IS_VEE_FOLDER (folder)) {
-			mark_all_as_read (folder);	
-		}
+		mark_all_as_read (folder);	
 		
 		fi = fi->next;
 	}
signature.asc (application/pgp-signature, 189 B) 
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)

iD8DBQBGkmQEfbrzscpaDCARAvKcAKC8kzbBEPudWYw/hGqbsetSlNpghQCgyW/Q
AbHHpQoScz6wWm6/D7B+iLo=
=1+aE
-----END PGP SIGNATURE-----