Re: Remove excess whitespace from password dialog

Ted,

Thanks a lot for your patch. It would be great, if you could post some
screenshots of how the new dialog will look like for the reviewers.

Also, Please create a bug and attach your patches in bugzilla. It is
always easy to track unreviewed patches and get them reviewed.

-Srini. 

On Sat, 2007-12-08 at 03:49 +1000, Ted Percival wrote:
> This patch removes a lot of the useless whitespace on the password 
> dialog (and an unnecessary GtkVBox in the process).
> 
> Please CC me on replies, or on a bug report, if this needs discussion.
> 
> plain text document attachment (eds-password_dialog.diff)
> --- evolution-data-server-1.12.2/libedataserverui/e-passwords.c	2007-10-12 16:29:40.000000000 +1000
> +++ evolution-data-server-1.12.2-new/libedataserverui/e-passwords.c	2007-12-08 03:29:08.000000000 +1000
> @@ -773,17 +773,14 @@
>  							       GTK_BUTTONS_OK_CANCEL,
>  							       "%s", msg->prompt);
>  	gtk_window_set_title(GTK_WINDOW(password_dialog), msg->title);
> +	gtk_container_set_border_width(GTK_CONTAINER(password_dialog), 12);
>  
>  	gtk_widget_ensure_style (GTK_WIDGET (password_dialog));
> -	gtk_container_set_border_width (GTK_CONTAINER (GTK_DIALOG (password_dialog)->vbox), 0);
> -	gtk_container_set_border_width (GTK_CONTAINER (GTK_DIALOG (password_dialog)->action_area), 12);
>  
>  	gtk_dialog_set_default_response(password_dialog, GTK_RESPONSE_OK);
>  
> -	vbox = gtk_vbox_new (FALSE, 12);
> -	gtk_widget_show (vbox);
> -	gtk_box_pack_start (GTK_BOX (GTK_DIALOG (password_dialog)->vbox), vbox, TRUE, FALSE, 0);
> -	gtk_container_set_border_width((GtkContainer *)vbox, 12);
> +	vbox = GTK_DIALOG(password_dialog)->vbox;
> +	gtk_box_set_spacing(GTK_BOX(vbox), 5);
>  	
>  	msg->entry = gtk_entry_new ();
>  
> @@ -791,7 +788,7 @@
>  	atk_object_set_description (a11y, msg->prompt);
>  	gtk_entry_set_visibility ((GtkEntry *)msg->entry, !(msg->flags & E_PASSWORDS_SECRET));
>  	gtk_entry_set_activates_default((GtkEntry *)msg->entry, TRUE);
> -	gtk_box_pack_start (GTK_BOX (vbox), msg->entry, TRUE, FALSE, 3);
> +	gtk_box_pack_start (GTK_BOX (vbox), msg->entry, TRUE, FALSE, 0);
>  	gtk_widget_show (msg->entry);
>  	gtk_widget_grab_focus (msg->entry);
>  	
> @@ -825,7 +822,7 @@
>  			
>  		}
>  		gtk_toggle_button_set_active (GTK_TOGGLE_BUTTON (msg->check), *msg->remember);
> -		gtk_box_pack_start (GTK_BOX (vbox), msg->check, TRUE, FALSE, 3);
> +		gtk_box_pack_start (GTK_BOX (vbox), msg->check, TRUE, FALSE, 0);
>  		if ((msg->flags & E_PASSWORDS_DISABLE_REMEMBER))
>  			gtk_widget_set_sensitive(msg->check, FALSE);
>  		gtk_widget_show (msg->check);
> _______________________________________________
> Evolution-patches mailing list
> [email protected]
> http://mail.gnome.org/mailman/listinfo/evolution-patches