Do not let message list steal focus

Jan Holesovsky <[email protected]> Tue, 19 Jan 2010 14:49:49 +0100
Newsgroups gmane.comp.gnome.evolution.patches
Message-ID <[email protected]>
--=-VvTZV4K5TnVR9zqlMANx
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit

Hi,

When using a mail client, I want to control it only using keyboard.  In
Evolution, the possibilities to move inside the message, and between
messages, include the Up and Down arrows (to move inside the message)
and Ctrl+], Ctrl+[, Ctrl+PgDn, and Ctrl+PgUp (to move between the
messages).

The problem is that any of Ctrl+], Ctrl+[, Ctrl+PgDn, Ctrl+PgUp steals
the focus from the message view, and gives it to message list - in which
case the meaning of Up and Down changes to moving between the messages
which I do not want - that is what Ctrl+PgDn and Ctrl+PgUp is for ;-) -
and you have to press Tab to get to the message view again.

The attached patch removes stealing of the focus - with that, you can
stay in the message preview & browse all your mail quickly and
effectively.

Please consider for inclusion.

Thank you,
Kendy

--=-VvTZV4K5TnVR9zqlMANx
Content-Disposition: attachment; filename="0004-Do-not-let-message-list-steal-focus.patch"
Content-Type: text/x-patch; name="0004-Do-not-let-message-list-steal-focus.patch"; charset="UTF-8"
Content-Transfer-Encoding: 7bit

From 44c190f8eba00944714f73fa91eb15af3e321868 Mon Sep 17 00:00:00 2001
From: Jan Holesovsky <[email protected]>
Date: Mon, 18 Jan 2010 20:51:43 +0100
Subject: [PATCH] Do not let message list steal focus.

Breaks the workflow of working in the message view, and moving between
messages using Ctrl+], Ctrl+[, Ctrl+PgDn, and Ctrl+PgUp.
---
 mail/message-list.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/mail/message-list.c b/mail/message-list.c
index 288b4a5..2ff1880 100644
--- a/mail/message-list.c
+++ b/mail/message-list.c
@@ -3469,8 +3469,6 @@ main_folder_changed (CamelObject *o, gpointer event_data, gpointer user_data)
 			}
 
 			camel_folder_change_info_free (changes);
-
-			g_signal_emit(ml, message_list_signals[MESSAGE_LIST_BUILT], 0);
 			return;
 		}
 	}
-- 
1.6.0.2


--=-VvTZV4K5TnVR9zqlMANx
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Evolution-patches mailing list
[email protected]
http://mail.gnome.org/mailman/listinfo/evolution-patches

--=-VvTZV4K5TnVR9zqlMANx--