/pidgin/main: 902b1fd334bd: Remove Gstreamer pipeline after play...

Changeset: 902b1fd334bd4d41ffd217fa4e6864629b7d3edc
Author:	 Jorge Villase?or <[email protected]>
Date:	 2015-10-07 23:39 -0700
Branch:	 release-2.x.y
URL: https://hg.pidgin.im/pidgin/main/rev/902b1fd334bd

Description:

Remove Gstreamer pipeline after playing a sound

When receiving an error or stream finished message, we can free the
Gstreamer pipeline so we don't leak it for each sound.

Patch from Sorokin Alexei, modified by me because the mediamanager
subsystem uses a different approach to watch the bus.
Fixes #16752

diffstat:

 finch/gntsound.c  |  1 +
 pidgin/gtksound.c |  1 +
 2 files changed, 2 insertions(+), 0 deletions(-)

diffs (22 lines):

diff --git a/finch/gntsound.c b/finch/gntsound.c
--- a/finch/gntsound.c
+++ b/finch/gntsound.c
@@ -449,6 +449,7 @@ bus_call (GstBus *bus, GstMessage *msg, 
 	case GST_MESSAGE_EOS:
 		gst_element_set_state(play, GST_STATE_NULL);
 		gst_object_unref(GST_OBJECT(play));
+		return FALSE;
 		break;
 	case GST_MESSAGE_WARNING:
 		gst_message_parse_warning(msg, &err, NULL);
diff --git a/pidgin/gtksound.c b/pidgin/gtksound.c
--- a/pidgin/gtksound.c
+++ b/pidgin/gtksound.c
@@ -394,6 +394,7 @@ bus_call (GstBus     *bus,
 	case GST_MESSAGE_EOS:
 		gst_element_set_state(play, GST_STATE_NULL);
 		gst_object_unref(GST_OBJECT(play));
+		return FALSE;
 		break;
 	case GST_MESSAGE_WARNING:
 		gst_message_parse_warning(msg, &err, NULL);

_______________________________________________
Commits mailing list
[email protected]
https://pidgin.im/cgi-bin/mailman/listinfo/commits