Re: chat windows opened in maximized state, stealing focus

--===============5103700934325639939==
Content-Type: multipart/signed; micalg=pgp-sha256;
 boundary="Sig_/kg00SYRxwRui4GLv=G52sSS"; protocol="application/pgp-signature"

--Sig_/kg00SYRxwRui4GLv=G52sSS
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

Am Fri, 14 Jun 2019 16:25:50 +0200
schrieb Konrad Gr=C3=A4fe <[email protected]>:

> The chats must be added to the buddy list.

They are there. How would they be able to autojoin?
Anyway, while I did read the mentioned github issue I did not realize the r=
ocketchat plugin is still broken after two years. A variant of this patch i=
s still required:

diff --git a/libpurple/protocols/rocketchat/librocketchat.c b/libpurple/pro=
tocols/rocketchat/librocketchat.c
index 56bb086b91..5a963f069b 100644
--- a/libpurple/protocols/rocketchat/librocketchat.c
+++ b/libpurple/protocols/rocketchat/librocketchat.c
@@ -2959,6 +2959,7 @@ rc_join_chat(PurpleConnection *pc, GHashTable *chatda=
ta)
 		chatconv =3D purple_conversations_find_chat_with_account(id, ya->account=
);
 	}
 	if (chatconv !=3D NULL && !purple_chat_conversation_has_left(chatconv)) {
+		if (0)
 		purple_conversation_present(PURPLE_CONVERSATION(chatconv));
 		return;
 	}
@@ -2968,6 +2969,7 @@ rc_join_chat(PurpleConnection *pc, GHashTable *chatda=
ta)
 		purple_conversation_set_data(PURPLE_CONVERSATION(chatconv), "id", g_strd=
up(id));
 	}
=20
+	if (0)
 	purple_conversation_present(PURPLE_CONVERSATION(chatconv));
=20
 	if (!g_hash_table_contains(ya->group_chats, id)) {

Now it works as expected. Thanks!

Olaf

--Sig_/kg00SYRxwRui4GLv=G52sSS
Content-Type: application/pgp-signature
Content-Description: Digitale Signatur von OpenPGP

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEE97o7Um30LT3B+5b/86SN7mm1DoAFAl0DsyQACgkQ86SN7mm1
DoA4MQ/9FGlJ++fRy32nmZHPuXEO9KpnHy2xsJn5HXfCvfnN7q7tKFWIr4acmSPC
dVb/YkRzA8gYEswmf8EH97cvmM+AFOR9f787ezQnjM5cwx+pwmgw84AK223iwKIA
Ba6jBEqVZRjd7YzjpCStRwulbwDPvtM7ZpW7Qr6u3lU6Ci8y1dM1tSVSJvQH7vZf
dZx3EHlhH+5V5rsJA9h4zobrXea+9mEWd+7o74gR673kepKC/MAcYMLKisIqTHB0
7Ed7SEOUudbYnCQ9071G5dH/Mm2uVebXnGDex2P9scX3E7Hie5bcIr3Q8jdpHTIn
h5wP1uHVsQwcDfCBD4vr6BvnFG3xF85P6qN2DE80ceYGQAyOyD5zlS+6yqcms2AO
gjkHlfGSFVHUcNRm+QcWDCgqqX+Y0ETF+F1sX/rMZqBJ1cEOhWQBuWPOpQWmkD4a
ZrrzgHpo7p9dqeys7j52ICxqUb5U8pNkiCxAkp/Lt+0lkVIGs68vEcjTx+y9xlZ5
uaQi+yPYh/6AciAe8K5BBtv2PFHn5EtC9MdAbkvMiqknCVv1zD5IGsFg+0Zd9J4E
vKTvHAv9wu4x7lM4ZttGlU2AJJSeFGCwbWgWMDSNcj/3VM9Km7DgcMoSyxUKCzQP
KqK+xm9n9G7KudtRYP+tCA+5ssNP8CURAyxcPi4Q6KaYO0kBoz4=
=5+Cv
-----END PGP SIGNATURE-----

--Sig_/kg00SYRxwRui4GLv=G52sSS--


--===============5103700934325639939==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: base64
Content-Disposition: inline

X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KRGV2ZWwgbWFp
bGluZyBsaXN0CkRldmVsQHBpZGdpbi5pbQpodHRwczovL2xpc3RzLnBpZGdpbi5pbS9saXN0aW5m
by9kZXZlbA==

--===============5103700934325639939==--