Re: [PATCH] GtkAssistant, GtkFrame, GtkExpander

ti, 2008-06-03 kello 14:06 -0300, Tristan Van Berkom kirjoitti:
> Hi,
>    Thankyou so much for taking the time to send us patches :)
> 
> For the assistant bug, I think there is one filed for it already, please look
> at the buglist and attach your patch there:
>     http://bugzilla.gnome.org/buglist.cgi?query=product%3Aglade3+

are you refering to this bug?:
[GtkAssistant (wizard) children are missing COMPLETE property]
http://bugzilla.gnome.org/show_bug.cgi?id=529595 

It's different bug as it needs an oneliner in gtk+.xml.in . Is there a
good reason why the 'complete' property is explicitly disabled?:

    <property id="complete" disabled="True"/>

$ svn blame plugins/gtk+/gtk+.xml.in |grep '<property id="complete"
disabled="True"/>'

  1001        jpu         <property id="complete" disabled="True"/>

$ svn log plugins/gtk+/gtk+.xml.in -r 1001
------------------------------------------------------------------------
r1001 | jpu | 2006-12-06 22:27:58 +0200 (ke, 06 joulu  2006) | 15 lines

* configure.in: added AC_CHECK_HEADERS(Python.h)

* src/glade-binding.[ch]: scripts indexed by GType name instead of GType
  this way we do not need glade_util_get_type_from_name() anymore.

* src/glade-widget-adaptor.c: fixed regression in
  gwa_setup_introspected_props_from_pspecs() Interface introduced
  properties where skipped.

* src/glade-gtk.c: Added GtkAssistant support code.

* widgets/gtk+.xml.in: Added gtk+ 2.10 widget classes.
  GtkAssistant, GtkLinkButton, GtkPageSetupUnixDialog,
  GtkPrintUnixDialog, GtkRecentChooserWidget and GtkRecentChooserDialog.

------------------------------------------------------------------------

If not, I can attach a patch for this.


> As for the expander and frame children, the problem here is that GtkBuilder
> uses a different name than libglade - your patch just throws the problem at
> libglade instead - althrough it should be pretty easy to either get the core
> to remember and recognize 2 names for child types (i.e. the builder name
> and the libglade name), or perhaps special case these cases at save/load time
> in the plugin.

I was under the impression that glade is moving to GtkBuilder and
libglade has become deprecated. Glade-3 from svn already saves projects
as GtkBuilder UI Definitions and libglade from svn does not understand
any of it, i.e. there is a problem with libglade already.


> Cheers,
>                       -Tristan
> 
> On Tue, Jun 3, 2008 at 1:30 PM, Antti Kaijanmäki <[email protected]> wrote:
> > Hi,
> >
> > I just wanted to send these patches. I'm not sure if they are correct as
> > I haven't dug very deep inside glade, but these have helped me get on
> > with my project[1].
> >
> >
> > fix_gtk_assistant_navigation_after_load.patch:
> >
> > * GtkAssistant can't be navigated after a project is loaded from file.
> >
> >
> > fix_gtk_frame_label_child_type.patch,
> > fix_gtk_expander_label_child_type.patch:
> >
> > * child types are wrong[2][3] causing GtkBuilder to segfault.
> >
> >
> > best regards,
> > Antti Kaijanmäki
> >
> > [1] http://www.kaijanmaki.net/blog
> > [2] http://library.gnome.org/devel/gtk/stable/GtkFrame.html
> > [3] http://library.gnome.org/devel/gtk/stable/GtkExpander.html
> >
> > _______________________________________________
> > Glade-devel maillist  -  [email protected]
> > http://lists.ximian.com/mailman/listinfo/glade-devel
> >
> >

_______________________________________________
Glade-devel maillist  -  [email protected]
http://lists.ximian.com/mailman/listinfo/glade-devel

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)

iD8DBQBIRi+WxyyCWWVycu8RAvImAKCIFTJ6bu/Tk/ND31i6LAlNmKRemQCgp/vr
naLPuqTI/lUxFVN6IxzkLFs=
=s7je
-----END PGP SIGNATURE-----