Re: [PATCH] GtkAssistant, GtkFrame, GtkExpander

ke, 2008-06-04 kello 11:37 -0300, Tristan Van Berkom kirjoitti:
> On Wed, Jun 4, 2008 at 3:00 AM, Antti Kaijanmäki <[email protected]> wrote:
> > ti, 2008-06-03 kello 14:06 -0300, Tristan Van Berkom kirjoitti:
> >> Hi,
> >>    Thankyou so much for taking the time to send us patches :)
> >>
> >> For the assistant bug, I think there is one filed for it already, please look
> >> at the buglist and attach your patch there:
> >>     http://bugzilla.gnome.org/buglist.cgi?query=product%3Aglade3+
> >
> > are you refering to this bug?:
> > [GtkAssistant (wizard) children are missing COMPLETE property]
> > http://bugzilla.gnome.org/show_bug.cgi?id=529595
> >
> 
> No, I was not reffering to a bug ;-) just saying that from memory I
> thought there already was one, so it would be better to just attach
> it there, we usually handle bugs in bugzilla - its easier for me :)

So, shall I open a new bug or is this handled for now?


> > It's different bug as it needs an oneliner in gtk+.xml.in . Is there a
> > good reason why the 'complete' property is explicitly disabled?:
> 
> Its a tough question that I havent got around to thinking what our
> policy should be concerning that - thats why I havent answered it
> yet.
> 
> The problem is that "complete" is a property that you would generally
> set programaticaly, depending on something in the assistant page itself,
> to show that that page is "currently complete", certainly doesnt fit
> into what glade does.

True. But in any case an assistant should be navigable inside glade.


> >> As for the expander and frame children, the problem here is that GtkBuilder
> >> uses a different name than libglade - your patch just throws the problem at
> >> libglade instead - althrough it should be pretty easy to either get the core
> >> to remember and recognize 2 names for child types (i.e. the builder name
> >> and the libglade name), or perhaps special case these cases at save/load time
> >> in the plugin.
> >
> > I was under the impression that glade is moving to GtkBuilder and
> > libglade has become deprecated. Glade-3 from svn already saves projects
> > as GtkBuilder UI Definitions and libglade from svn does not understand
> > any of it, i.e. there is a problem with libglade already.
> 
> Glade trunk loads and saves files in libglade format with little or no
> regressions
> right now, it also supports conversions between the 2 formats and provides
> error reports about which widgets/properties are supported in which
> format/version.
> (see either the project->properties dialog or the format switch when saving).

Well as I said I haven't dug deep inside glade and this was something I
didn't know ;P

Anyway I now have a custom version of glade-3 that outputs GtkBuilder UI
Definitions that I can process with stock gtk. Hopefully this child type
gets sorted out during the summer :)

 -- Antti


> Because gtkbuilder is preffered, it is the naturally the default
> format for new projects.
> 
> Cheers and sincerely thanks for your support,
>               -Tristan

_______________________________________________
Glade-devel maillist  -  [email protected]
http://lists.ximian.com/mailman/listinfo/glade-devel

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)

iD8DBQBIRt93xyyCWWVycu8RAoqJAJ9EBg55h3BfL6VOORu0vU8vCYKPsQCeIMkD
/FUGhOfJQq2towPAhhzp968=
=pDYM
-----END PGP SIGNATURE-----