Re: A (not so) little issue at gladeui/glade-project.c:1492

--===============1857752768==
Content-Type: multipart/signed; micalg="pgp-sha1"; protocol="application/pgp-signature";
	boundary="=-qMKm/nM5LXsJa1hZlDIq"


--=-qMKm/nM5LXsJa1hZlDIq
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi Juan!

> In gladeui/glade-project.c:1492, the call to g_free (required_lib) not
> always leave required_lib in NULL, at least for me, so the condition !
> required_lib fail in the remaining bucles. Of cource, this occurs when
> I use more than one requires-tag and can't use my own plugins.

I don't fully see your point. required_lib is free'd in the last else
branch and when the loop continues, the first thing is to initialize it
to NULL
(https://git.gnome.org/browse/glade/tree/gladeui/glade-project.c#n1443).
So it shouldn't be a problem that it isn't being set to NULL.

Sidenote: The correct way to free it and set it to NULL would be
g_clear_pointer (&required_lib, g_free) but that shouldn't be necessary
here.


Regards,
Johannes


--=-qMKm/nM5LXsJa1hZlDIq
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iEYEABECAAYFAlTm4vwACgkQAvZZn2XJ+bOAwgCdHPvpH0lG4zpxpuMlG6E+40iF
9x4AoJ+gry8Lq17PyRr3waHsfFBkE16m
=d+Hg
-----END PGP SIGNATURE-----

--=-qMKm/nM5LXsJa1hZlDIq--


--===============1857752768==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Glade-devel maillist  -  [email protected]
http://lists.ximian.com/mailman/listinfo/glade-devel

--===============1857752768==--