Re: Accelerator key inconsistencies

On Tue, Aug 08, 2006 at 05:02:23PM +0100, Martyn Russell wrote:
> On Tue, 2006-08-08 at 17:44 +0200, CJ van den Berg wrote:
> > Why does Ctrl-w close a chat window and esc close the roster window? Should
> > Gossip at least use one or the other consistently? (or even both if you
> > want)
> 
> Ctrl+W is only used for closing tabs, if you close the last tab, it
> closes the window. 

Nautilus, Epiphany, Abiword, Gnumeric, Gimp, Audacity... all close the
window on Ctrl-w. Basically every GNOME application that opens more than one
top level window. The only one I found that doesn't is gedit. Who's side do
you want to be on? ;)

> > I'm used to using Ctrl-w in most GNOME applications to say "close this
> > window but not the whole app". IIRC, esc is only for dialog windows.
> 
> Yes I agree, Escape (if I had my way) would only close dialogs, but some
> people insist on making it minimise the main window. I personally don't
> use it. 

So why not use both and be consistent with other GNOME applications *and*
make "some people" happy?

> > I just noticed too, that "hide contact list" (or whatever it used to be
> > called) has disappeared from the menu in 0.14.
> 
> I guess it is because of:
> 
> 	if (!gossip_have_tray ()) {
> 		hidden = FALSE;
> 		gtk_widget_hide (GTK_WIDGET (priv->actions_hide_list));
> 
> It was broken, the else statement didn't call gtk_widget_show() so I
> guess it was hidden in the glade file?
> 
> Anyway, thanks, I have committed a fix.

Ah, that explains it, thanks! :D

-- 
CJ van den Berg

mailto:[email protected]
  xmpp:[email protected]

_______________________________________________
Gossip-dev mailing list
[email protected]
http://lists.imendio.com/mailman/listinfo/gossip-dev

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (GNU/Linux)

iD8DBQFE2LkFl3pZXfh0CHIRAheXAKDkq9g4yLiAicHklDgkDu8c8CPrUQCeKoO3
Qa4O+ClzC8Dzapqe1LQhclE=
=Y6U0
-----END PGP SIGNATURE-----