Re: [Telepathy] rework of the UI

On Tue, 2006-09-12 at 12:12 +0200, Xavier Claessens wrote:
> Le mardi 12 septembre 2006 à 10:20 +0100, Martyn Russell a écrit :
> > On Tue, 2006-09-12 at 01:14 -0700, Eitan Isaacson wrote:
> > > On Tue, 2006-09-12 at 08:13 +0100, Martyn Russell wrote:
> > > > On Tue, 2006-09-12 at 00:43 +0200, Xavier Claessens wrote:
> > > > > Here is what I have so far [1].
> > > > > 
> > > > > 1) code cleanup in many places
> > > > > 
> > > > > 2) removes those modules and merge changes in normal module:
> > > > > gossip-new-account-window-telepathy.[ch]
> > > > > gossip-accounts-dialog-telepathy.[ch]
> > > > > 
> > > > > 3) As said GossipAccount uses the GHashTable for
> > > > > gossip_account_get/set_*(). Rework the whole API.
> > > > 
> > > > The gossip_account_() API should probably use g_dataset_() here instead
> > > > of g_hash_table_(). Not sure though.
> > > 
> > > Do you mean, g_datalist? if so I agree. I'm not sure what the benefits
> > > of g_dataset_() are.
> > 
> > Yes.
> > 
> > If I am honest, I haven't used them before and didn't know they existed,
> > but from reading the docs, it sounds like the right thing to use.
> 
> btw, this change should be considered for including in HEAD. I know head
> doesn't need that but it's not telepathy specific, the code runs without
> telepathy and since it's a big rework of GossipAccount it will be very
> difficult to keep this module in sync with head...
> 
> Another problem is that is break config file, so the user will have to
> remake all his accounts, maybe can we work on a migration code to
> convert xml files and/or support both formats ?

Well, in the past we have made sure the user can seamlessly use the next
version of Gossip without knowing about these sort of changes (if
possible).

What would be good is if you could write a patch for GossipAccount and
the dtd and something which will migrate the old to the new config, then
it would be considered for HEAD.

-- 
Regards,
Martyn