Re: [Telepathy] rework of the UI

Hi,

I just took a very quick look at the patch:

* Please try to avoid whitespace-only changes

* Use g_object_set() instead of setting up a gvalue and using
g_object_set_property (and when using g_object_set, don't cast the object).

* g_value_transform looks suspicious, is that right? don't you just want
to copy the value?

* What's the reason for having the function that returns a hash table
with all params?

* The quark args should not be called param_name, since they are not
names, but quarks, however...

* ...what's the reason really to have a datalist, when a hashtable would
work just as fine and probably be simpler and less code?

/Richard

-- 
Imendio AB, http://www.imendio.com/