Re: [Telepathy] rework of the UI

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

13 sep 2006 kl. 18.38 skrev Xavier Claessens:

Hi,

> First of all thanks for comments !
>
>> * Please try to avoid whitespace-only changes
> yes but they should be fixed... I fix them when I see a wrong
> indentation and it's not easy to make a different patch for each
> white-space bug...

I know the problem, I have a hard time staying away from those myself  
when I run over them at projects I don't maintain. However, including  
them in the patch does make the work of going over the patch take a  
lot longer.

I'd say, leave style changes to the maintainer, he will get around to  
the eventually as he work over code paths where they are.

If you feel strongly about it, make a bunch into it's own patch and  
send those in without any functional changes.

Best Regards,
   Mikael Hallendal

- --
Imendio AB, http://www.imendio.com


-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (Darwin)

iD8DBQFFEJegcCUF7/xF8ZsRAnAqAJ0QNaGT9i3J26PcwE3Vs77XChkTRwCgufvB
ZRdp7KHOtwQtTyiXnIgSYXU=
=lZiF
-----END PGP SIGNATURE-----