Re: [Telepathy] development status

On Sun, 2006-09-24 at 01:55 +0200, Xavier Claessens wrote:
> Le dimanche 24 septembre 2006 à 00:30 +0200, Xavier Claessens a écrit :
> Ok so here is the patch [1]. It does:
> 
> 1) Sync GossipAccount changes with HEAD.
> 2) Add telepathy specific code for GossipAccount(Manager).
> 3) Use the same UI for new-account and account-dialog than HEAD.
> 
> Adding a new telepathy account seems to crash
> because /usr/local/share/telepathy/managers/ doesn't exist here. I don't
> know what's the problem :-(

Thanks Xavier, I have done the following on the TELEPATHY branch:

      * Committed Xavier's patch.
      * Moved the code from telepathy/ to protocols/telepathy/
      * Gone through the telepathy backend code and make sure it
        complies with our coding standards (might have missed some
        places).
      * Fixed some critical issues with the code so Gossip doesn't now
        crash on startup.
      * Made Gossip use either the Jabber backend we already have *OR*
        Telepathy, before it was ALWAYS using the Jabber backend. 

There are some issues with the current code, the main one being that the
spec[1] for the connection manager has changed slightly.

Eitan and all committing to this branch:

      * PLEASE make sure you follow the coding standards outlined[2], it
        saves me and others time and effort when reviewing, etc.
      * Don't cast unnecessarily.
      * Don't use g_error() in the backend.
      * Don't use g_printerr(), use g_warning() or gossip_debug()
        instead.
      * There is no need to use return; as the last line in a void
        function, so omit that in the future please.
      * Don't #include files that are not necessary - I know it is easy
        to forget to do this when copying from other .[ch] files.

Overall, things are looking quite good at the moment, but a little more
work is needed. Currently I can't use SSL with Telepathy and the Jabber
protocol, but my testing account on Jabber.org works perfectly in the
most basic actions. This might just be that Gossip isn't actually
setting the SSL variables up correctly when it talks to Telepathy
though.

Great work guys, keep it up!

[1] http://telepathy.freedesktop.org/wiki/ManagerFileFormat
[2] http://developer.imendio.com/codingstyle

-- 
Regards,
Martyn

_______________________________________________
Gossip-dev mailing list
[email protected]
http://lists.imendio.com/mailman/listinfo/gossip-dev

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.3 (GNU/Linux)

iD8DBQBFFoLTwpLEnE7M298RAvzLAKC3WDrD3QOM17t+LBOCGCgbp84J+QCglhNi
/INvRnRpXCgYkrzI1VG9O5w=
=eZQE
-----END PGP SIGNATURE-----