final account rework
Xavier Claessens <[email protected]> Sun, 01 Oct 2006 18:46:16 +0200
| Newsgroups | gmane.comp.gnome.gossip.devel |
|---|---|
| Message-ID | <1159721176.5791.21.camel@zdra-desktop> |
Hi, I'm working on protocol specific UI for creating and editing accounts [1]. This work is made for HEAD and will be very useful for telepathy. One of the goal of this is removing the deprecated gossip_account_[get,set]_*() API and use instead the new API gossip_account_param_set(). I'm surprised there is not many places where the deprecated API is used, most of it is in my new gossip-account-jabber.[ch] module, that's why I'm thinking about removing this API completely now. For that I need one think: the protocol should create new accounts with default values for all parameters. Something like GossipAccount *gossip_protocol_create_account (GossipProtocol*); With telepathy it is already the protocol that creates new accounts and it already sets all parameters with default values (Eitan correct me if I miss understood the code). In telepathy we directly call gossip_telepathy_cmgr_new_account_from_protocol from protocol/telepathy/ which violate the libgossip abstraction. Is that a good idea if I implement all that in my next big account rework ? Maybe it's better to make many little patches than one big ? btw, new_account_window_get_account_info() has changed in last commit in the THELEPATHY branch and don't have the telepathy specific code anymore ! what happened ? Xavier Claessens. [1] http://bugzilla.gnome.org/show_bug.cgi?id=358099 _______________________________________________ Gossip-dev mailing list [email protected] http://lists.imendio.com/mailman/listinfo/gossip-dev
signature.asc
(application/pgp-signature, 189 B)
-----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.3 (GNU/Linux) iD8DBQBFH/DY6dEBUn2qPAMRAmyAAKCKX0nP+KXsY8vkQJNlVVfNFXvKzgCfYJjx cyGA+9GB7zAmQJrqcmtzJ0Q= =6Ar8 -----END PGP SIGNATURE-----