Re: final account rework
Richard Hult <[email protected]> Fri, 06 Oct 2006 22:45:27 +0200
| Newsgroups | gmane.comp.gnome.gossip.devel |
|---|---|
| Organization | Imendio AB |
| Message-ID | <[email protected]> |
Xavier Claessens skrev: > The patch > http://users.skynet.be/Zdra/gossip-account.patch This patch looks OK to me in general. I assume that you have tested it so that it works and so on :) I would call the new_account function create_account. > New files in src/ > http://users.skynet.be/Zdra/gossip-account-jabber.c > http://users.skynet.be/Zdra/gossip-account-jabber.h > http://users.skynet.be/Zdra/gossip-account-unknown.c > http://users.skynet.be/Zdra/gossip-account-unknown.h Should the latter be called -generic? Unknown sounds a bit odd to me. I'd also prefer to have some kind of indication that we are talking about a dialog/window here, gossip-account-dialog-jabber for example. /Richard -- Imendio AB, http://www.imendio.com/