Re: final account rework
Martyn Russell <[email protected]> Sat, 07 Oct 2006 21:07:32 +0100
| Newsgroups | gmane.comp.gnome.gossip.devel |
|---|---|
| Message-ID | <[email protected]> |
Richard Hult wrote: > Xavier Claessens skrev: >> Le vendredi 06 octobre 2006 à 23:18 +0200, Xavier Claessens a écrit : >>> Ok I can rename to gossip-account-generic. It's not a window nor a >>> dialog, it's a widget... So what about gossip-account-jabber-widget ? >>> >> >> Hum, I was renaming the module but I realised: >> >> GossipAccountGenericWidget >> GossipAccountJabberWidget >> >> Those are too long names. I first named it GossipAccountSettingsJabber >> and Martyn agreed it was too long. What do you suggest ? Just replace >> "unknown" by "generic" ? > > I would call them > > GossipAccountWidgetJabber and GossipAccountWidgetGeneric > > That is not longer than other stuff we already have. Yea :) This is all committed now, thanks Richard for reviewing, I have tested the original patch and added some usability to it, including: - Show a message dialog when registration succeeds not just when it fails. - Make the registration success/failure message dialog asynchronous (i.e. don't call gtk_dialog_run()). - Set the focus to the name of the account when adding a new one. - Make the blurb on the settings side of the window slightly more user friendly when no account is selected/available. - Try to reduce the horrible resizing when no account is selected. - Don't allow the 'Register' button to be available when no account is selected. - Don't show the account name/proxy/auto-connect settings when no account is selected. All-in-all a superb patch, thanks Xavier. -- Regards, Martyn