Re: [PATCH] GossipContact should emit himself property notifications and updated signal

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Xavier Claessens wrote:
> On sam, 2006-12-09 at 13:26 +0100, Xavier Claessens wrote:
>> Hi,
>>
>> I made a big patch [1]. Comments are welcomed. I think it needs testing
>> to be sure to not have regressions, it's why I post on the ML.
>>
>> So please test the patch and tell me if contact's information are always
>> updated everywhere on the UI.
>>
>> Thanks.
>>
>> Xavier Claessens.
>>
> 
> Same kind of thing: Why is signal "chatroom-contact-joined" emitted on
> the GossipProtocol ? Shouldn't it be emitted on the chatroom itself ?
> 
> If there is a special reason please tell me :-)

It is interesting you say this. I was recently doing the group chat
changes so that the join all happens in gossip-group-chat.c and I
realised that there is a join callback we specify with the join request
as well as a join signal. So there really is no need for both. Really
the join signal should be emitted with the reasons without the need for
a callback.

Regarding the "chatroom-contact-joined" signal, this is interesting,
because "joined" is not a property and if I recall, the signal would be
emitted from the backend, so I am not sure it really makes sense to have
the signals in the GossipChatroom module, typically you signal from
within the module itself, it might be weird to have the backend do the
signalling that way, not sure? Comments?

Also, I noticed that we have a "changed" signal for the GossipChatroom,
we should be able to use "notify" I think.

- --
Regards,
Martyn
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.3 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFFe+K0wpLEnE7M298RAtIoAJ9JlF41/wLfjDE58u69pDXD6Cc2aQCgkLZ7
ou5P7e5MVLaS2uDZOplXTug=
=EOG3
-----END PGP SIGNATURE-----