Re: GossipChatroomContact must die ?

14 dec 2006 kl. 15.12 skrev Xavier Claessens:

Hi,

> Hello,
>
> With telepathy a contact can be in the roster and in a chatroom at the
> same time, it doesn't make any difference for avatar/presence/alias/ 
> etc.
> In libgossip we make the difference between GossipContact and
> GossipChatroomContact because there are 2 more properties: affiliation
> and role.

As discussed on IRC yesterday I said I would get back on this on the  
mailing list.

> I discussed that with Martyn we see only 2 solutions:
>
> 1) We move affiliation/role properties to GossipContact and remove
> GossipChatrooContact class.

This won't work as affiliation/role (and in Jabber nick name) varies  
between chatrooms. Ie. you can be moderator in one chat room and  
participant in another. And if we continue to use one GossipContact  
per chatroom I don't see a reason for changing this at all.

> 2) Store a contact list into GossipChatroom to map for each contact a
> small struct containing his affiliation/role in this chatroom. This  
> have
> the advantage that the same GossipContact object can be added to more
> than one chatroom with different role/affiliation.

While this would work for most cases it still has the problem when  
you private chat with someone through a chatroom as supported by  
Jabber. I think (someone prove me wrong if that is not the case) that  
we need to support chatting with JID  
[email protected]/Nickname even though we can read  
out his real JID through the chatroom.

I don't generally have a huge problem with leaving it as it is,  
changing it would mean we would save some bytes for IRC and non- 
anonymous chatrooms.

For now I would suggest leaving it as it is and sort it out in the  
backend.

Best Regards,
   Mikael Hallendal

--
Imendio AB, http://www.imendio.com