Re: Complying with HIG - libgnomeui/gnome-app-helper
jacob berkman <[email protected]> 29 Apr 2002 15:44:12 -0400
| Newsgroups | gmane.comp.gnome.lib.devel |
|---|---|
| Message-ID | <1020109452.6485.62.camel@wet-pants> |
On Mon, 2002-04-29 at 07:39, Glynn Foster wrote: > Hey, > I've added some code [1] so that we stand some chance of complying with > the HIG for 2.0. This addresses - > > http://bugzilla.gnome.org/show_bug.cgi?id=80016 > > I guess this mail is just a check that we're not doing anything ugly > elsewhere that can be fixed up nicely now. marking the old things deprecated actually breaks stuff. i've applied that attached patch which un-deprecates it. if you want to re-deprecate, bring it up with the release team. jacob -- "don't get me wrong, i think that radiohead are amazing. i love their music and i love their ethos, but that thom yorke guy always seems to be complaining." -- moby
gnome-app-helper.patch
(text/x-patch, 1.2 KB)
Index: gnome-app-helper.h
===================================================================
RCS file: /cvs/gnome/libgnomeui/libgnomeui/gnome-app-helper.h,v
retrieving revision 1.90
diff -u -r1.90 gnome-app-helper.h
--- gnome-app-helper.h 29 Apr 2002 11:31:15 -0000 1.90
+++ gnome-app-helper.h 29 Apr 2002 19:41:47 -0000
@@ -126,12 +126,8 @@
GNOME_APP_CONFIGURABLE_ITEM_END_GAME
} GnomeUIInfoConfigurableTypes;
-#ifndef GNOME_DISABLE_DEPRECATED
-
#define GNOME_APP_CONFIGURABLE_ITEM_EXIT GNOME_APP_CONFIGURABLE_ITEM_QUIT
-#endif
-
/* These values identify the type of pixmap used in an item */
typedef enum {
GNOME_APP_PIXMAP_NONE, /* No pixmap specified */
@@ -343,12 +339,7 @@
GNOME_APP_PIXMAP_NONE, NULL, \
GNOME_APP_CONFIGURABLE_ITEM_CLOSE, (GdkModifierType) 0, NULL }
-#ifndef GNOME_DISABLE_DEPRECATED
-
#define GNOMEUIINFO_MENU_EXIT_ITEM(cb, data) GNOMEUIINFO_MENU_QUIT_ITEM(cb, data)
-
-#endif
-
#define GNOMEUIINFO_MENU_QUIT_ITEM(cb, data) \
{ GNOME_APP_UI_ITEM_CONFIGURABLE, NULL, NULL, \
(gpointer)cb, (gpointer)(data), NULL, \