Re: Patch to fix ICU flush and pivot buffer

On 25/10/2017 17:40, Markus Scherer wrote:
> On Wed, Oct 25, 2017 at 4:02 AM, Nick Wellnhofer <[email protected] 
>     The patch changes public function xmlCharEncInFunc but this function isn't
>     used internally anymore (since commit a78d8036 from 2012). It might still
>     be used in client code that wants to use libxml2's character conversion
>     facilities, though. Maybe it's better to remove the `flush` parameter and
>     always call xmlEncInputChunk with `flush` set to 1. This should at least
>     allow one-shot character conversions without breaking the public API.
> 
> The ICU conversion functions must be called with flush=FALSE before the end of 
> the stream, and with flush=TRUE at the end of the stream.

Yes, but I'm only talking about xmlCharEncInFunc which isn't used internally.

Nick