Re: [PATCH] always dllexport the singlethreaded variables

On 04/09/2018 11:00, Michael Haubenwallner wrote:
> Right now, LIBXML_THREAD_ENABLED is defined in xmlversion.h only if the
> *application* does enable threads

OK, I thought that LIBXML_THREAD_ENABLED only depends on the configure switch, 
but it also depends on the following check in xmlversion.h:

#if defined(_REENTRANT) || defined(__MT__) || \
     (defined(_POSIX_C_SOURCE) && (_POSIX_C_SOURCE - 0 >= 199506L))

https://gitlab.gnome.org/GNOME/libxml2/blob/master/include/libxml/xmlversion.h.in#L87

This looks wrong to me. If libxml2 was compiled with threads, 
LIBXML_THREAD_ENABLED should always be defined.

Nick