Re: [PATCH] Fix xmlURIEscape memory leaks.

enh via xml <[email protected]> Thu, 5 Nov 2020 15:54:52 -0800
Newsgroups gmane.comp.gnome.lib.xml.general
Message-ID <CAJgzZorgMCugzOTfX2QY9bU-ufLYqmDvCCQDO7uZdbzyZiKkjQ@mail.gmail.com>
ping?

(let me know if this should be a pull request somewhere instead...)

On Tue, Oct 27, 2020 at 11:33 AM enh <[email protected]> wrote:
>
> Found by running the fuzz/uri.c fuzzer under asan (internal Android bug
> 171610679).
>
> Always free `ret` when exiting on failure. I've moved the definition of
> NULLCHK down past where ret is always initialized to make it clear that
> this is safe.
>
> This patch also fixes the indentation of two of the NULLCHK call sites
> to make it more obvious that NULLCHK isn't `if`-like.
> ---
>  uri.c | 17 +++++++++--------
>  1 file changed, 9 insertions(+), 8 deletions(-)