Re: [PATCH] Fix xmlURIEscape memory leaks.
Nick Wellnhofer via xml <[email protected]> Mon, 9 Nov 2020 18:32:38 +0100
| Newsgroups | gmane.comp.gnome.lib.xml.general |
|---|---|
| Message-ID | <[email protected]> |
Merged here: https://gitlab.gnome.org/GNOME/libxml2/-/commit/7c06d99e1f4f853e3c5b307c0dc79c8a32a09855 Nick On 27/10/2020 19:33, enh via xml wrote: > Found by running the fuzz/uri.c fuzzer under asan (internal Android bug > 171610679). > > Always free `ret` when exiting on failure. I've moved the definition of > NULLCHK down past where ret is always initialized to make it clear that > this is safe. > > This patch also fixes the indentation of two of the NULLCHK call sites > to make it more obvious that NULLCHK isn't `if`-like. > --- > uri.c | 17 +++++++++-------- > 1 file changed, 9 insertions(+), 8 deletions(-)