Re: [PATCH 1/3] Modernize configure script

On Mon, Sep 17, 2012 at 12:28:37AM +0300, Roumen Petrov wrote:
> Hi Thierry,
> 
> 
> Thierry Reding wrote:
> >On Sun, Sep 16, 2012 at 06:33:37PM +0300, Roumen Petrov wrote:
> >>Thierry Reding wrote:
> >>>[SNIP]
> >>>  configure.ac | 716 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> >>>  configure.in | 715 ----------------------------------------------------------
> >>>[snip]
> >>It is not possible to follow  updates with such patch.
> >>Why do not keep as is and to left to Daniel to rename in the future ?
> >I should have generated this with git format-patch -M, that would have
> >detected the rename. I can resend if necessary.
> 
> No idea how git handle file rename send in patch file. On PC with
> repository I have "ancient" git 1.6.4 and you patch may is not
> suitable for this version.
> 
> Based on you change in Makefile.am I guest that you would like to
> propose something like "0012-libtool-2-rules.patch". Such change was
> not acceptable before recently updates, .i.e configure script is
> with LT_INIT.

Yes, that's part of what the patch does. It also updates AC_INIT and
AM_INIT_AUTOMAKE usage because recent autotools are starting to
complain.

> Also those days I note that libxslt use own INSTALL file and this
> require AUTOMAKE_OPTIONS = foreign to be added to toplevel
> Makefile.am and this explain why is not in attached file.

That should be taken care of by my patch as well. It passes the foreign
option to AM_INIT_AUTOMAKE so you don't have to list it in Makefile.am.

> Please could  to send configure diff separately . It will be more
> easy to review.

I just resent the patch with rename detection enabled so it is easier to
see what was changed.

Thierry

_______________________________________________
xslt mailing list, project page http://xmlsoft.org/XSLT/
[email protected]
https://mail.gnome.org/mailman/listinfo/xslt

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.19 (GNU/Linux)

iQIcBAEBAgAGBQJQVrwuAAoJEN0jrNd/PrOhWwsP/3sq6gW6QSQwavrP2Gz9Rbi2
M6LKGp+5KNb5tKgdJoAnZk9cnDSIB5gcb5qlcKfJYckZBezT8A1Cn6sLJaTKFT2J
z1CLaKq3NveJ+trtO/sf0svQCaWrBrIZQb1UlDBVyad7nUiuz5Q+0hGIIO4KDTwk
ditDC486JK0J5JLHgToHDdVZ5O3bVUnrqYxKt/SKPZaL3aRCKo3dq4fI7wRDuJ5S
O+vOFwqnQvdN2bIfHGfQT9Mi3mT3r2AGdXiaLyxjgMZbza2kpfEhVcG8real94qL
6ETYfGik8Msi6TEmhBQ5ITWt4OJ+oKdZUZ9b5/cFDWlQH4u5zPQb5aAT4e79XQCZ
i73QHJHoanl7cO89Lq7IUP9YJKEIPVtrbGfbwGYhbQzQ0nRhM8FmVpfUB341tHDr
Kl6PUZUcNYEJpDW8gmfw9lDL2SYWXkWL6r0cifVr07c4/es+50GGaJ5uOonKKVhs
lw9+XoSdyONzLQdrEN/09PZ38VXntHkpR3Lwxa8lntALb2vPuI5fJgmfwkldtFY+
8JKqnCI4fpLiEBlnUa1eDMJoss+fT6tbcSlVSmhiFDGNIpPXL7G2jp/Q7xbTjbq8
W0lyUiX1oFOGqol+8RS0hs0UMmyAORt7PL/lNWdJ/w+MeT1kyKz82oZAdkZLJ2zD
/ilmABuYMIr7JadRZw/a
=ifN/
-----END PGP SIGNATURE-----