Re: [PATCH] really declare dllexport/dllimport for Cygwin
Nick Wellnhofer <[email protected]> Fri, 31 Aug 2018 11:48:01 +0200
| Newsgroups | gmane.comp.gnome.lib.xslt |
|---|---|
| Message-ID | <[email protected]> |
Thanks, patch applied here: https://gitlab.gnome.org/GNOME/libxslt/commit/6abf3c481cf12ecd2b0a8fc5f2903e15d8904673 On 29/05/2018 11:59, Michael Haubenwallner wrote: > Cygwin does not define _WIN32, but still requires dllexport/dllimport > tags for when applications use the --disable-auto-import linker flag, > probably set by the gl_WOE32_DLL autoconf macro in woe32-dll.m4 file. > --- > libexslt/exsltexports.h | 4 ++-- > libxslt/xsltexports.h | 4 ++-- > 2 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/libexslt/exsltexports.h b/libexslt/exsltexports.h > index bead915c..21c49a4a 100644 > --- a/libexslt/exsltexports.h > +++ b/libexslt/exsltexports.h > @@ -111,8 +111,8 @@ > #endif > #endif > > -/* Cygwin platform, GNU compiler */ > -#if defined(_WIN32) && defined(__CYGWIN__) > +/* Cygwin platform (does not define _WIN32), GNU compiler */ > +#if defined(__CYGWIN__) > #undef EXSLTPUBFUN > #undef EXSLTPUBVAR > #undef EXSLTCALL > diff --git a/libxslt/xsltexports.h b/libxslt/xsltexports.h > index 825c122e..37b43bf2 100644 > --- a/libxslt/xsltexports.h > +++ b/libxslt/xsltexports.h > @@ -113,8 +113,8 @@ > #endif > #endif > > -/* Cygwin platform, GNU compiler */ > -#if defined(_WIN32) && defined(__CYGWIN__) > +/* Cygwin platform (does not define _WIN32), GNU compiler */ > +#if defined(__CYGWIN__) > #undef XSLTPUBFUN > #undef XSLTPUBVAR > #undef XSLTCALL >