Re: [PATCH] Make sure mkbundle executables work if they are run from a path on the PATH environment variable.

Zoltan Varga <[email protected]> Fri, 1 Dec 2017 14:15:50 -0500
Newsgroups gmane.comp.gnome.mono.devel
Message-ID <CAJR-0p-80ymJKeqY5Be4dSK85Sv=Ytqqvc48qzCswURF25MLVw@mail.gmail.com>
Hi,

 The best way to submit patches nowdays is through github PRs:

https://github.com/mono/mono/pulls

   Zoltan

On Fri, Dec 1, 2017 at 2:12 PM, R Zaghi <[email protected]> wrote:

> This is a patch to enable mkbundle executable files to work when they are
> run from a path that is on the PATH environment variable.
>
> Mono mini has a function probe_embedded() which looks for the program's
> file (using argv[0]). If the program is run from a path on the PATH
> environment variable then the open() fails and only a single parameter is
> sent to the mono_main() which in turn causes an if condition to print the
> help and exit.
>
> This patch searches through the directories specified in the current
> environment's PATH variable and tries to open() then first file found.
>
> Apologies if this is not the right way to submit patches but I had a quick
> look at the contribution page online and my understanding is that I must
> send a patch this to the community with the most likely or relevant
> owner(s) on the CC.
>
> Please let me know if I need to do anything else to push this (change
> log!?).
>
>
> Thanks
>
>
>
> Ramin Zaghi
>
> *Mosaic3DX™ | User Interface Technology*
> St John's Innovation Centre,
> Cowley Road,
> Cambridge,
> CB4 0WS, UK
> *E*: [email protected]
> *T*: +44 1223 421 311 <+44%201223%20421311>
> http://linkedin.com/in/raminzaghi
>
>
>

_______________________________________________
Mono-devel-list mailing list
[email protected]
http://lists.dot.net/mailman/listinfo/mono-devel-list