Re: Building mono-core
Jo Shields via Mono-devel-list <[email protected]> Fri, 2 Feb 2018 17:42:41 +0000
| Newsgroups | gmane.comp.gnome.mono.devel |
|---|---|
| Message-ID | <VI1PR83MB01104ED7A65A6EFCDDC68DD0DBF90@VI1PR83MB0110.EURPRD83.prod.outlook.com> |
--===============7600721420973768350== Content-Language: en-GB Content-Type: multipart/alternative; boundary="_000_VI1PR83MB01104ED7A65A6EFCDDC68DD0DBF90VI1PR83MB0110EURP_" --_000_VI1PR83MB01104ED7A65A6EFCDDC68DD0DBF90VI1PR83MB0110EURP_ Content-Type: text/plain; charset="Windows-1252" Content-Transfer-Encoding: quoted-printable Relevant pull request: https://github.com/mono/mono/pull/5251 Mono is now the canonical home of Roslyn, and MSbuild uses the Mono-provide= d binaries, not its own. Sent from Outlook<http://aka.ms/weboutlook> ________________________________ From: Alexander K=F6plinger Sent: 02 February 2018 12:06 To: Neale Ferguson Cc: Mono Devel Mailing List; Jo Shields Subject: Re: [Mono-dev] Building mono-core Hm, that's a packaging question for Jo (added on CC). On 2 Feb 2018, at 18:03, Neale Ferguson <[email protected]<mailto:neale@= sinenomine.net>> wrote: What=92s the proposed fix for msbuild living in =96devel and msbuild? Will = msbuild contain all the Roslyn stuff that can be removed from -devel? From: Alexander K=F6plinger <[email protected]<mailto:[email protected]= om>> Date: Friday, February 2, 2018 at 11:43 AM To: Neale Ferguson <[email protected]<mailto:[email protected]>> Cc: Mono Devel Mailing List <[email protected]<mailto:mono-deve= [email protected]>> Subject: Re: [Mono-dev] Building mono-core Ahh, sorry, you're talking about the mono-core.spec :D Yes, replacing .pdb there should work. I guess we can take that improvement= as well? On 2 Feb 2018, at 17:41, Alexander K=F6plinger via Mono-devel-list <mono-de= [email protected]<mailto:[email protected]>> wrote: Which %files entry are you talking about? On 2 Feb 2018, at 17:39, Neale Ferguson <[email protected]<mailto:neale@= sinenomine.net>> wrote: I got rid of the pdbs from the %files sections and rebuilt so the logs have= been overwritten. I just replaced the %files entries that had xxxx.exe* wi= th xxxx.* as that would work for exe/exe.so/pdb/mdb. From: Alexander K=F6plinger <[email protected]<mailto:[email protected]= om>> Date: Friday, February 2, 2018 at 11:36 AM To: Neale Ferguson <[email protected]<mailto:[email protected]>> Cc: Mono Devel Mailing List <[email protected]<mailto:mono-deve= [email protected]>> Subject: Re: [Mono-dev] Building mono-core This is the PR template that was inherited from the upstream repo, I just c= hanged the copy in our fork :) For the PDBs: they are only generated by Roslyn csc which I think isn't the= default on s390x. However, we shouldn't _require_ them anywhere, it should= fallback to picking the .mdb's from mcs. Could you please post a full build log? - Alex On 2 Feb 2018, at 17:29, Neale Ferguson <[email protected]<mailto:neale@= sinenomine.net>> wrote: I cloned mono/boringssl, created a branch, made my changes, committed and p= ushed them. When I went to generate a PR: Please do not send pull requests to the BoringSSL repository. We do, however, take contributions gladly. See https://boringssl.googlesource.com/boringssl/+/master/CONTRIBUTING.md<h= ttps://na01.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fboringssl= .googlesource.com%2Fboringssl%2F%2B%2Fmaster%2FCONTRIBUTING.md&data=3D02%7C= 01%7Calkpli%40microsoft.com%7Ccf319b8103724694a3c608d56a5b819f%7Cee3303d7fb= 734b0c8589bcd847f1c277%7C1%7C0%7C636531863611649124&sdata=3DM94cyKQ6N3qb7xJ= 8XS%2FLFrVe5gmMgCtztHDKO4EKoBA%3D&reserved=3D0> Thanks! From: Neale Ferguson <[email protected]<mailto:[email protected]>> Date: Friday, February 2, 2018 at 11:01 AM To: Alexander K=F6plinger <[email protected]<mailto:[email protected]= >> Cc: Mono-Devel <[email protected]<mailto:mono-devel-list@lis= ts.ximian.com>> Subject: Re: [Mono-dev] Building mono-core Hey Neale, would you mind opening a pull request on GitHub with the BTLS ch= anges for s390x? - Will do. I=92ll checkout the latest copy and reapply Could you please list which pdb's it complains about? - All of them. No pdb files are created for the s390x build. What are they = and how are the created? _______________________________________________ Mono-devel-list mailing list [email protected]<mailto:[email protected]> https://na01.safelinks.protection.outlook.com/?url=3Dhttp%3A%2F%2Flists.dot= .net%2Fmailman%2Flistinfo%2Fmono-devel-list&data=3D02%7C01%7Calkpli%40micro= soft.com%7C567cbcd1c9c6445403b108d56a5bd6d4%7Cee3303d7fb734b0c8589bcd847f1c= 277%7C1%7C0%7C636531865043986428&sdata=3DBNnIEDEN9CBA%2B0u6728E2pNoU17%2B13= mF38%2BKOJ0bL0s%3D&reserved=3D0 --_000_VI1PR83MB01104ED7A65A6EFCDDC68DD0DBF90VI1PR83MB0110EURP_ Content-Type: text/html; charset="Windows-1252" Content-Transfer-Encoding: quoted-printable <html> <head> <meta http-equiv=3D"Content-Type" content=3D"text/html; charset=3DWindows-1= 252"> <style type=3D"text/css" style=3D"display:none;"> P {margin-top:0;margin-bo= ttom:0;} </style> </head> <body dir=3D"ltr"> <div style=3D"font-family: Calibri, Arial, Helvetica, sans-serif; font-size= : 12pt; color: rgb(0, 0, 0); background-color: rgba(0, 0, 0, 0);"> Relevant pull request: <a href=3D"https://github.com/mono/mono/pull/5251" i= d=3D"LPNoLPLPlnk260194"> https://github.com/mono/mono/pull/5251</a><br> <br> Mono is now the canonical home of Roslyn, and MSbuild uses the Mono-provide= d binaries, not its own.<br> <br> </div> <div style=3D"font-family: Calibri, Arial, Helvetica, sans-serif; font-size= : 12pt; color: rgb(0, 0, 0);"> <br> </div> <div id=3D"signature"> <p>Sent from <a href=3D"http://aka.ms/weboutlook">Outlook</a><br> </p> </div> <hr style=3D"display:inline-block;width:98%" tabindex=3D"-1"> <div id=3D"divRplyFwdMsg" dir=3D"ltr"><font face=3D"Calibri, sans-serif" st= yle=3D"font-size:11pt" color=3D"#000000"><b>From:</b> Alexander K=F6plinger= <br> <b>Sent:</b> 02 February 2018 12:06<br> <b>To:</b> Neale Ferguson<br> <b>Cc:</b> Mono Devel Mailing List; Jo Shields<br> <b>Subject:</b> Re: [Mono-dev] Building mono-core</font> <div> </div> </div> <div class=3D"" style=3D"word-wrap:break-word">Hm, that's a packaging quest= ion for Jo (added on CC). <div class=3D""><br class=3D""> </div> <div class=3D""><br class=3D""> <div> <blockquote type=3D"cite" class=3D""> <div class=3D"">On 2 Feb 2018, at 18:03, Neale Ferguson <<a href=3D"mail= to:[email protected]" class=3D"">[email protected]</a>> wrote:</di= v> <br class=3D"x_Apple-interchange-newline"> <div class=3D""> <div class=3D"" style=3D"word-wrap:break-word; font-size:14px; font-family:= Calibri,sans-serif"> <div class=3D"">What=92s the proposed fix for msbuild living in =96devel an= d msbuild? Will msbuild contain all the Roslyn stuff that can be removed fr= om -devel?</div> <div class=3D""><br class=3D""> </div> <span id=3D"OLK_SRC_BODY_SECTION" class=3D""> <div class=3D"" style=3D"font-family:Calibri; font-size:11pt; text-align:le= ft; border-width:1pt medium medium; border-style:solid none none; padding:3= pt 0in 0in; border-top-color:rgb(181,196,223)"> <span class=3D"" style=3D"font-weight:bold">From: </span>Alexander K=F6plin= ger <<a href=3D"mailto:[email protected]" class=3D"">alkpli@microsoft= .com</a>><br class=3D""> <span class=3D"" style=3D"font-weight:bold">Date: </span>Friday, February 2= , 2018 at 11:43 AM<br class=3D""> <span class=3D"" style=3D"font-weight:bold">To: </span>Neale Ferguson <<= a href=3D"mailto:[email protected]" class=3D"">[email protected]</a>&= gt;<br class=3D""> <span class=3D"" style=3D"font-weight:bold">Cc: </span>Mono Devel Mailing L= ist <<a href=3D"mailto:[email protected]" class=3D"">mono-de= [email protected]</a>><br class=3D""> <span class=3D"" style=3D"font-weight:bold">Subject: </span>Re: [Mono-dev] = Building mono-core<br class=3D""> </div> <div class=3D""><br class=3D""> </div> <div class=3D""> <div class=3D"" style=3D"word-wrap:break-word">Ahh, sorry, you're talking a= bout the mono-core.spec :D <div class=3D""><br class=3D""> </div> <div class=3D"">Yes, replacing .pdb there should work. I guess we can take = that improvement as well?</div> <div class=3D""><br class=3D""> </div> <div class=3D""><br class=3D""> <div class=3D""> <blockquote type=3D"cite" class=3D""> <div class=3D"">On 2 Feb 2018, at 17:41, Alexander K=F6plinger via Mono-dev= el-list <<a href=3D"mailto:[email protected]" class=3D"">mon= [email protected]</a>> wrote:</div> <br class=3D"x_Apple-interchange-newline"> <div class=3D""> <div class=3D"" style=3D"word-wrap:break-word">Which %files entry are you t= alking about? <div class=3D""><br class=3D""> </div> <div class=3D""><br class=3D""> <div class=3D""> <blockquote type=3D"cite" class=3D""> <div class=3D"">On 2 Feb 2018, at 17:39, Neale Ferguson <<a href=3D"mail= to:[email protected]" class=3D"">[email protected]</a>> wrote:</di= v> <br class=3D"x_Apple-interchange-newline"> <div class=3D""> <div class=3D"" style=3D"word-wrap:break-word; font-size:14px; font-family:= Calibri,sans-serif"> <div class=3D"">I got rid of the pdbs from the %files sections and rebuilt = so the logs have been overwritten. I just replaced the %files entries that = had xxxx.exe* with xxxx.* as that would work for exe/exe.so/pdb/mdb. <= /div> <div class=3D""><br class=3D""> </div> <span id=3D"OLK_SRC_BODY_SECTION" class=3D""> <div class=3D"" style=3D"font-family:Calibri; font-size:11pt; text-align:le= ft; border-width:1pt medium medium; border-style:solid none none; padding:3= pt 0in 0in; border-top-color:rgb(181,196,223)"> <span class=3D"" style=3D"font-weight:bold">From: </span>Alexander K=F6plin= ger <<a href=3D"mailto:[email protected]" class=3D"">alkpli@microsoft= .com</a>><br class=3D""> <span class=3D"" style=3D"font-weight:bold">Date: </span>Friday, February 2= , 2018 at 11:36 AM<br class=3D""> <span class=3D"" style=3D"font-weight:bold">To: </span>Neale Ferguson <<= a href=3D"mailto:[email protected]" class=3D"">[email protected]</a>&= gt;<br class=3D""> <span class=3D"" style=3D"font-weight:bold">Cc: </span>Mono Devel Mailing L= ist <<a href=3D"mailto:[email protected]" class=3D"">mono-de= [email protected]</a>><br class=3D""> <span class=3D"" style=3D"font-weight:bold">Subject: </span>Re: [Mono-dev] = Building mono-core<br class=3D""> </div> <div class=3D""><br class=3D""> </div> <div class=3D""> <div class=3D"" style=3D"word-wrap:break-word">This is the PR template that= was inherited from the upstream repo, I just changed the copy in our fork = :) <div class=3D""><br class=3D""> </div> <div class=3D"">For the PDBs: they are only generated by Roslyn csc which I= think isn't the default on s390x. However, we shouldn't _require_ them any= where, it should fallback to picking the .mdb's from mcs.</div> <div class=3D"">Could you please post a full build log?</div> <div class=3D""><br class=3D""> </div> <div class=3D"">- Alex</div> <div class=3D""> <div class=3D""><br class=3D""> </div> <div class=3D""><br class=3D""> <div class=3D""> <blockquote type=3D"cite" class=3D""> <div class=3D"">On 2 Feb 2018, at 17:29, Neale Ferguson <<a href=3D"mail= to:[email protected]" class=3D"">[email protected]</a>> wrote:</di= v> <br class=3D"x_Apple-interchange-newline"> <div class=3D""> <div class=3D"" style=3D"word-wrap:break-word; font-size:14px; font-family:= Calibri,sans-serif"> <div class=3D"">I cloned mono/boringssl, created a branch, made my changes,= committed and pushed them. When I went to generate a PR:</div> <div class=3D""><br class=3D""> </div> <div class=3D""> <div class=3D"">Please do not send pull requests to the BoringSSL repositor= y.</div> <div class=3D""><br class=3D""> </div> <div class=3D"">We do, however, take contributions gladly.</div> <div class=3D""><br class=3D""> </div> <div class=3D"">See <a href=3D"https://na01.safelinks.protection.outlook.co= m/?url=3Dhttps%3A%2F%2Fboringssl.googlesource.com%2Fboringssl%2F%2B%2Fmaste= r%2FCONTRIBUTING.md&data=3D02%7C01%7Calkpli%40microsoft.com%7Ccf319b810= 3724694a3c608d56a5b819f%7Cee3303d7fb734b0c8589bcd847f1c277%7C1%7C0%7C636531= 863611649124&sdata=3DM94cyKQ6N3qb7xJ8XS%2FLFrVe5gmMgCtztHDKO4EKoBA%3D&a= mp;reserved=3D0" class=3D""> https://boringssl.googlesource.com/boringssl/+/master/CONTRIBUTING.md</= a></div> <div class=3D""><br class=3D""> </div> <div class=3D"">Thanks!</div> </div> <div class=3D""><br class=3D""> </div> <span id=3D"OLK_SRC_BODY_SECTION" class=3D""> <div class=3D"" style=3D"font-family:Calibri; font-size:11pt; text-align:le= ft; border-width:1pt medium medium; border-style:solid none none; padding:3= pt 0in 0in; border-top-color:rgb(181,196,223)"> <span class=3D"" style=3D"font-weight:bold">From: </span>Neale Ferguson <= ;<a href=3D"mailto:[email protected]" class=3D"">[email protected]</a= >><br class=3D""> <span class=3D"" style=3D"font-weight:bold">Date: </span>Friday, February 2= , 2018 at 11:01 AM<br class=3D""> <span class=3D"" style=3D"font-weight:bold">To: </span>Alexander K=F6plinge= r <<a href=3D"mailto:[email protected]" class=3D"">[email protected]= om</a>><br class=3D""> <span class=3D"" style=3D"font-weight:bold">Cc: </span>Mono-Devel <<a hr= ef=3D"mailto:[email protected]" class=3D"">mono-devel-list@l= ists.ximian.com</a>><br class=3D""> <span class=3D"" style=3D"font-weight:bold">Subject: </span>Re: [Mono-dev] = Building mono-core<br class=3D""> </div> <div class=3D""><br class=3D""> </div> <div class=3D""> <div class=3D"" style=3D"word-wrap:break-word; font-size:14px; font-family:= Calibri,sans-serif"> <div class=3D""><br class=3D""> </div> <span id=3D"OLK_SRC_BODY_SECTION" class=3D""> <div class=3D""> <div class=3D"" style=3D"word-wrap:break-word">Hey Neale, would you mind op= ening a pull request on GitHub with the BTLS changes for s390x? <div class=3D"">- Will do. I=92ll checkout the latest copy and reapply</div= > </div> </div> </span> <div class=3D""><br class=3D""> </div> <span id=3D"OLK_SRC_BODY_SECTION" class=3D""> <div class=3D""> <div class=3D"" style=3D"word-wrap:break-word"> <div class=3D"">Could you please list which pdb's it complains about?</div> </div> </div> </span> <div class=3D"">- All of them. No pdb files are created for the s390x build= . What are they and how are the created?</div> </div> </div> </span></div> </div> </blockquote> </div> <br class=3D""> </div> </div> </div> </div> </span></div> </div> </blockquote> </div> <br class=3D""> </div> </div> _______________________________________________<br class=3D""> Mono-devel-list mailing list<br class=3D""> <a href=3D"mailto:[email protected]" class=3D"">Mono-devel-list= @lists.dot.net</a><br class=3D""> <a href=3D"https://na01.safelinks.protection.outlook.com/?url=3Dhttp%3A%2F%= 2Flists.dot.net%2Fmailman%2Flistinfo%2Fmono-devel-list&data=3D02%7C01%7= Calkpli%40microsoft.com%7C567cbcd1c9c6445403b108d56a5bd6d4%7Cee3303d7fb734b= 0c8589bcd847f1c277%7C1%7C0%7C636531865043986428&sdata=3DBNnIEDEN9CBA%2B= 0u6728E2pNoU17%2B13mF38%2BKOJ0bL0s%3D&reserved=3D0" class=3D"">https://= na01.safelinks.protection.outlook.com/?url=3Dhttp%3A%2F%2Flists.dot.net%2Fm= ailman%2Flistinfo%2Fmono-devel-list&data=3D02%7C01%7Calkpli%40microsoft= .com%7C567cbcd1c9c6445403b108d56a5bd6d4%7Cee3303d7fb734b0c8589bcd847f1c277%= 7C1%7C0%7C636531865043986428&sdata=3DBNnIEDEN9CBA%2B0u6728E2pNoU17%2B13= mF38%2BKOJ0bL0s%3D&reserved=3D0</a><br class=3D""> </div> </blockquote> </div> <br class=3D""> </div> </div> </div> </span></div> </div> </blockquote> </div> <br class=3D""> </div> </div> </body> </html> --_000_VI1PR83MB01104ED7A65A6EFCDDC68DD0DBF90VI1PR83MB0110EURP_-- --===============7600721420973768350== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KTW9uby1kZXZl bC1saXN0IG1haWxpbmcgbGlzdApNb25vLWRldmVsLWxpc3RAbGlzdHMuZG90Lm5ldApodHRwOi8v bGlzdHMuZG90Lm5ldC9tYWlsbWFuL2xpc3RpbmZvL21vbm8tZGV2ZWwtbGlzdAo= --===============7600721420973768350==--