Re: [PATCH] Generics Support for monodoc/tools

Jonathan Pryor wrote:
>> At the URL below is a patch to monodoc/tools to add support for Generics
>> to monodocer.exe and monodocs2html.exe.  (Next stop: adding support for
>> Generics to the documentation browser.)

Hey,

Comments for the monodocer part of the patch:

After running it on some of my docs, I get these unexpected changes:

-        <ReturnType>SemWeb.N3Writer+Formats</ReturnType>
+        <ReturnType>SemWeb.N3Writer.Formats</ReturnType>

(I'm not necessarily opposed to such a change, but I thought that was
part of what was undone about "+" vs ".".)

- <Parameter Name="prefix" Type="System.String&amp;" RefType="out" />
+ <Parameter Name="prefix" Type="System.String&amp;" RefType="out">
+  <Attributes>
+   <Attribute>
+    <AttributeName>System.Runtime.InteropServices.Out</AttributeName>
+   </Attribute>
+  </Attributes>
+ </Parameter>

Is "out" exposed differently through reflection in 2.0?  I think we
should suppress this attribute, since it duplicates RefType.

Also (but this is related to the +/. thing), during an update the
index.xml file was updated by adding entries like:

  <Type Name="Sparql.QueryType" File="Sparql+QueryType" />

but without removing the old entry with the "+" in the name.

Lastly, the File attribute wasn't added to any existing entries in
index.xml when doing a doc update.

Looking forward to all the updates.

-- 
- Joshua Tauberer

http://razor.occams.info

"Strike up the klezmer and start acting like a man. You're
about to have a truth-mitzvah."  -- The Colbert Report
_______________________________________________
Mono-docs-list maillist  -  [email protected]
http://lists.ximian.com/mailman/listinfo/mono-docs-list