[mono/mono] [2 commits] 1df124c6: FixBuild

   Branch: refs/heads/monotouch-7.0.2-branch
     Home: https://github.com/mono/mono
  Compare: https://github.com/mono/mono/compare/63714aeff208...ba8730379c75

   Commit: 1df124c6b356a6db137d3254d9f5f38658ee3ac1
   Author: Miguel de Icaza <[email protected]> (migueldeicaza)
Committer: Sebastien Pouliot <[email protected]> (spouliot)
     Date: 2013-10-04 21:13:05 GMT
      URL: https://github.com/mono/mono/commit/1df124c6b356a6db137d3254d9f5f38658ee3ac1

FixBuild

Changed paths:
  M mcs/class/System.ComponentModel.DataAnnotations/System.ComponentModel.DataAnnotations/EmailAddressAttribute.cs

Modified: mcs/class/System.ComponentModel.DataAnnotations/System.ComponentModel.DataAnnotations/EmailAddressAttribute.cs
===================================================================
@@ -40,7 +40,6 @@ namespace System.ComponentModel.DataAnnotations
 	public class EmailAddressAttribute : DataTypeAttribute
 	{
 		private const string DefaultErrorMessage = "The {0} field is not a valid e-mail address.";
-		private static Regex _emailRegex = new Regex (_emailRegexStr, RegexOptions.IgnoreCase | RegexOptions.Compiled);
 
 		public EmailAddressAttribute ()
 			: base(DataType.EmailAddress)

   Commit: ba8730379c7525dd6d19789a746c371cb6474e94
   Author: Sebastien Pouliot <[email protected]> (spouliot)
     Date: 2013-10-04 21:13:18 GMT
      URL: https://github.com/mono/mono/commit/ba8730379c7525dd6d19789a746c371cb6474e94

Ignore some asserts since the validation were removed

Changed paths:
  M mcs/class/System.ComponentModel.DataAnnotations/Test/System.ComponentModel.DataAnnotations/CreditCardAttributeTest.cs
  M mcs/class/System.ComponentModel.DataAnnotations/Test/System.ComponentModel.DataAnnotations/EmailAddressAttributeTest.cs

Modified: mcs/class/System.ComponentModel.DataAnnotations/Test/System.ComponentModel.DataAnnotations/CreditCardAttributeTest.cs
===================================================================
@@ -51,7 +51,9 @@ public void IsValid ()
 			Assert.IsTrue (sla.IsValid ("378282246310005"), "#A1-4");
 			Assert.IsTrue (sla.IsValid ("3782-8224-6310-005"), "#A1-5");
 			Assert.IsTrue (sla.IsValid ("371449635398431"), "#A-6");
+#if false
 			Assert.IsFalse (sla.IsValid ("371449635498431"), "#A-6b");
+#endif
 			Assert.IsFalse (sla.IsValid (true), "#A1-7");
 			Assert.IsFalse (sla.IsValid (DateTime.Now), "#A1-8");
 		}

Modified: mcs/class/System.ComponentModel.DataAnnotations/Test/System.ComponentModel.DataAnnotations/EmailAddressAttributeTest.cs
===================================================================
@@ -46,8 +46,10 @@ public void IsValid ()
 			var sla = new EmailAddressAttribute ();
 
 			Assert.IsTrue (sla.IsValid (null), "#A1-1");
+#if false
 			Assert.IsFalse (sla.IsValid (String.Empty), "#A1-2");
 			Assert.IsFalse (sla.IsValid ("string"), "#A1-3");
+#endif
 			Assert.IsTrue (sla.IsValid ("[email protected]"), "#A1-4");
 			Assert.IsTrue (sla.IsValid ("[email protected]"), "#A1-5");
 			Assert.IsFalse (sla.IsValid (123), "#A1-6");


_______________________________________________
Mono-patches maillist  -  [email protected]
http://lists.ximian.com/mailman/listinfo/mono-patches