[mono/mono] [2 commits] e1a16245: When generating resources, it intends to add the .resources file to the FilesWritten list. However, it sets the ItemSpec on the wrong item, and a 'Clean' ends up deleting the .resx file.

   Branch: refs/heads/master
     Home: https://github.com/mono/mono
  Compare: https://github.com/mono/mono/compare/0075f3921505...87f80d1139d5

   Commit: e1a1624504ae76be13fd81865b26ed2c7877d2e3
   Author: R. Brian Lindahl <[email protected]> 
     Date: 2013-09-25 15:40:43 GMT
      URL: https://github.com/mono/mono/commit/e1a1624504ae76be13fd81865b26ed2c7877d2e3

When generating resources, it intends to add the .resources file to the FilesWritten list. However, it sets the ItemSpec on the wrong item, and a 'Clean' ends up deleting the .resx file.

Changed paths:
  M mcs/class/Microsoft.Build.Tasks/Microsoft.Build.Tasks/GenerateResource.cs

Modified: mcs/class/Microsoft.Build.Tasks/Microsoft.Build.Tasks/GenerateResource.cs
===================================================================
@@ -82,7 +82,7 @@ public override bool Execute ()
 						result &= CompileResourceFile (sourceFile, outputFile);
 
 					ITaskItem newItem = new TaskItem (source);
-					source.ItemSpec = outputFile;
+					newItem.ItemSpec = outputFile;
 
 					temporaryFilesWritten.Add (newItem);
 				}

   Commit: 87f80d1139d559d7883da118f1ee2951b0e06856
   Author: Atsushi Eno <[email protected]> (atsushieno)
     Date: 2013-10-18 07:49:51 GMT
      URL: https://github.com/mono/mono/commit/87f80d1139d559d7883da118f1ee2951b0e06856

Merge pull request #766 from remobjects/resx-delete-on-clean

When generating resources, it intends to add the .resources file to the ...

Changed paths:
  M mcs/class/Microsoft.Build.Tasks/Microsoft.Build.Tasks/GenerateResource.cs

Modified: mcs/class/Microsoft.Build.Tasks/Microsoft.Build.Tasks/GenerateResource..cs
===================================================================
@@ -82,7 +82,7 @@ public override bool Execute ()
 						result &= CompileResourceFile (sourceFile, outputFile);
 
 					ITaskItem newItem = new TaskItem (source);
-					source.ItemSpec = outputFile;
+					newItem.ItemSpec = outputFile;
 
 					temporaryFilesWritten.Add (newItem);
 				}


_______________________________________________
Mono-patches maillist  -  [email protected]
http://lists.ximian.com/mailman/listinfo/mono-patches