[mono/monodevelop] 7db62e01: minor code cleanup thanks to code analysis

   Branch: refs/heads/master
     Home: https://github.com/mono/monodevelop
  Compare: https://github.com/mono/monodevelop/compare/d2dff0202372...7db62e017296

   Commit: 7db62e017296cddfa627d5c4205219cb1265e812
   Author: Jeffrey Stedfast <[email protected]> (jstedfast)
     Date: 2013-10-18 18:40:12 GMT
      URL: https://github.com/mono/monodevelop/commit/7db62e017296cddfa627d5c4205219cb1265e812

minor code cleanup thanks to code analysis

Changed paths:
  M main/src/core/MonoDevelop.Core/MonoDevelop.Core/FileService.cs
  M main/src/core/MonoDevelop.Core/MonoDevelop.Projects/Project.cs

Modified: main/src/core/MonoDevelop.Core/MonoDevelop.Core/FileService.cs
===================================================================
@@ -50,11 +50,11 @@ public static class FileService
 		static FileServiceErrorHandler errorHandler;
 		
 		static FileSystemExtension fileSystemChain;
-		static FileSystemExtension defaultExtension = Platform.IsWindows ? new DefaultFileSystemExtension () : new UnixFileSystemExtension () ;
+		static readonly FileSystemExtension defaultExtension = Platform.IsWindows ? new DefaultFileSystemExtension () : new UnixFileSystemExtension () ;
 		
-		static EventQueue eventQueue = new EventQueue ();
+		static readonly EventQueue eventQueue = new EventQueue ();
 		
-		static string applicationRootPath = Path.Combine (PropertyService.EntryAssemblyPath, "..");
+		static readonly string applicationRootPath = Path.Combine (PropertyService.EntryAssemblyPath, "..");
 		public static string ApplicationRootPath {
 			get {
 				return applicationRootPath;
@@ -249,7 +249,7 @@ public static bool RequestFileEdit (string fileName)
 		/// <summary>
 		/// Requests permission for modifying a file
 		/// </summary>
-		/// <param name="fileName">The file to be modified</param>
+		/// <param name="fileName">The file to be modified</param>
 		/// <remarks>This method must be called before trying to write any file. It throws an exception if permission is not granted.</remarks>
 		public static bool RequestFileEdit (FilePath fileName, bool throwIfFails = true)
 		{


Modified: main/src/core/MonoDevelop.Core/MonoDevelop.Projects/Project.cs
===================================================================
@@ -61,7 +61,7 @@ public abstract class Project : SolutionEntityItem
 	{
 		string[] buildActions;
 
-		public Project ()
+		protected Project ()
 		{
 			FileService.FileChanged += OnFileChanged;
 			files = new ProjectFileCollection ();


_______________________________________________
Mono-patches maillist  -  [email protected]
http://lists.ximian.com/mailman/listinfo/mono-patches