[mono/monodevelop] [2 commits] 061f8c79: [NUnit] Use the pathname

"Alan McGovern ([email protected])" <[email protected]>
Newsgroups gmane.comp.gnome.mono.patches
Message-ID <00000141e8cb21e7-f41844bb-80e9-4d14-bd42-13533dea9675-000000@email.amazonses.com>
   Branch: refs/heads/master
     Home: https://github.com/mono/monodevelop
  Compare: https://github.com/mono/monodevelop/compare/6fbadae887ad...b39f68fa0056

   Commit: 061f8c79d6066c8d2e0f23ed42171154b7a1e47d
   Author: alan <[email protected]> 
     Date: 2013-10-24 04:46:07 GMT
      URL: https://github.com/mono/monodevelop/commit/061f8c79d6066c8d2e0f23ed42171154b7a1e47d

[NUnit] Use the pathname

The pathname is the correct thing to use, not the suitename
and testname.

The pathname handles tests subclassing other tests in the correct manner

Changed paths:
  M main/src/addins/NUnit/Services/NUnitAssemblyTestSuite.cs

Modified: main/src/addins/NUnit/Services/NUnitAssemblyTestSuite.cs
===================================================================
@@ -472,11 +472,9 @@ UnitTestResult RunWithConsoleRunner (ProcessExecutionCommand cmd, UnitTest test,
 					cmd.Arguments += " ";
 				cmd.Arguments += "\"-xml=" + outFile + "\" " + AssemblyPath;
 
-				bool automaticUpdates = cmd.Command.Contains ("GuiUnit") || (cmd.Command.Contains ("mdtool.exe") && cmd.Arguments.Contains ("run-md-tests"));
-				if (!string.IsNullOrEmpty (testName))
-					cmd.Arguments += " -run=" + suiteName + "." + testName;
-				else if (!string.IsNullOrEmpty (suiteName))
-					cmd.Arguments += " -run=" + suiteName;
+				bool automaticUpdates = cmd.Command.Contains ("GuiUnit") || (cmd.Command.Contains ("mdtool.exe") && cmd.Arguments.Contains ("run-md-tests"));
+				if (!string.IsNullOrEmpty(pathName))
+					cmd.Arguments += " -run=" + pathName;
 				if (automaticUpdates) {
 					tcpListener = new MonoDevelop.NUnit.External.TcpTestListener (localMonitor, suiteName);
 					cmd.Arguments += " -port=" + tcpListener.Port;

   Commit: b39f68fa0056f6c9d02b8fcb39a003799af7e401
   Author: alan <[email protected]> 
     Date: 2013-10-24 04:46:08 GMT
      URL: https://github.com/mono/monodevelop/commit/b39f68fa0056f6c9d02b8fcb39a003799af7e401

[NUnit] Ignore casing when comparing extensions

Changed paths:
  M main/tests/TestRunner/Runner.cs

Modified: main/tests/TestRunner/Runner.cs
===================================================================
@@ -30,18 +30,19 @@
 using System.Collections.Generic;
 using Mono.Addins;
 using System.Linq;
-using Mono.Addins.Description;
+using Mono.Addins.Description;
+using System.Diagnostics;
 
 namespace MonoDevelop.Tests.TestRunner
 {
 	public class Runer: IApplication
 	{
 		public int Run (string[] arguments)
-		{
+		{
 			var args = new List<string> (arguments);
 			bool useGuiUnit = false;
 			foreach (var ar in args) {
-				if ((ar.EndsWith (".dll", StringComparison.Ordinal) || ar.EndsWith (".exe", StringComparison.Ordinal)) && File.Exists (ar)) {
+				if ((ar.EndsWith (".dll", StringComparison.OrdinalIgnoreCase) || ar.EndsWith (".exe", StringComparison.OrdinalIgnoreCase)) && File.Exists (ar)) {
 					try {
 						var path = Path.GetFullPath (ar);
 						var asm = Assembly.LoadFrom (path);


_______________________________________________
Mono-patches maillist  -  [email protected]
http://lists.ximian.com/mailman/listinfo/mono-patches
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.