[mono/monodevelop] 0b462d0f: [Subversion] Switch many classes to internal, since they don't need to be public.

"Therzok ([email protected])" <[email protected]>
Newsgroups gmane.comp.gnome.mono.patches
Message-ID <00000141effd702c-fa56c3fb-ce96-4c93-a6a7-dd2238b0e372-000000@email.amazonses.com>
   Branch: refs/heads/hideAPI
     Home: https://github.com/mono/monodevelop
  Compare: https://github.com/mono/monodevelop/compare/fc623ac326a5...0b462d0f8cc0

   Commit: 0b462d0f8cc0e85d9da9a660cf3880e9be7aa27c
   Author: Therzok <[email protected]> (Therzok)
     Date: 2013-10-25 14:18:52 GMT
      URL: https://github.com/mono/monodevelop/commit/0b462d0f8cc0e85d9da9a660cf3880e9be7aa27c

[Subversion] Switch many classes to internal, since they don't need to be public.

Changed paths:
  M main/src/addins/VersionControl/MonoDevelop.VersionControl.Subversion.Unix/AssemblyInfo.cs
  M main/src/addins/VersionControl/MonoDevelop.VersionControl.Subversion.Unix/MonoDevelop.VersionControl.Subversion.Unix/LibApr.cs
  M main/src/addins/VersionControl/MonoDevelop.VersionControl.Subversion.Unix/MonoDevelop.VersionControl.Subversion.Unix/LibSvnClient.cs
  M main/src/addins/VersionControl/MonoDevelop.VersionControl.Subversion.Unix/MonoDevelop.VersionControl.Subversion.Unix/LibSvnClient0.cs
  M main/src/addins/VersionControl/MonoDevelop.VersionControl.Subversion.Unix/MonoDevelop.VersionControl.Subversion.Unix/LibSvnClient1.cs
  M main/src/addins/VersionControl/MonoDevelop.VersionControl.Subversion.Unix/MonoDevelop.VersionControl.Subversion.Unix/SvnClient.cs
  M main/src/addins/VersionControl/MonoDevelop.VersionControl.Subversion/AssemblyInfo.cs
  M main/src/addins/VersionControl/MonoDevelop.VersionControl.Subversion/MonoDevelop.VersionControl.Subversion.Gui/ClientCertificateDialog.cs
  M main/src/addins/VersionControl/MonoDevelop.VersionControl.Subversion/MonoDevelop.VersionControl.Subversion.Gui/ClientCertificatePasswordDialog.cs
  M main/src/addins/VersionControl/MonoDevelop.VersionControl.Subversion/MonoDevelop.VersionControl.Subversion.Gui/SslServerTrustDialog.cs
  M main/src/addins/VersionControl/MonoDevelop.VersionControl.Subversion/MonoDevelop.VersionControl.Subversion.Gui/UserPasswordDialog.cs
  M main/src/addins/VersionControl/MonoDevelop.VersionControl.Subversion/gtk-gui/MonoDevelop.VersionControl.Subversion.Gui.ClientCertificateDialog.cs
  M main/src/addins/VersionControl/MonoDevelop.VersionControl.Subversion/gtk-gui/MonoDevelop.VersionControl.Subversion.Gui.ClientCertificatePasswordDialog.cs
  M main/src/addins/VersionControl/MonoDevelop.VersionControl.Subversion/gtk-gui/MonoDevelop.VersionControl.Subversion.Gui.SslServerTrustDialog.cs
  M main/src/addins/VersionControl/MonoDevelop.VersionControl.Subversion/gtk-gui/MonoDevelop.VersionControl.Subversion.Gui.UserPasswordDialog.cs
  M main/src/addins/VersionControl/MonoDevelop.VersionControl.Subversion/gtk-gui/gui.stetic
  M main/src/addins/VersionControl/Subversion.Win32/Properties/AssemblyInfo.cs
  M main/src/addins/VersionControl/Subversion.Win32/SvnSharpClient.cs

Modified: main/src/addins/VersionControl/MonoDevelop.VersionControl.Subversion.Unix/AssemblyInfo.cs
===================================================================
@@ -50,3 +50,4 @@
 //[assembly: AssemblyDelaySign(false)]
 //[assembly: AssemblyKeyFile("")]
 
+[assembly: InternalsVisibleTo ("MonoDevelop.VersionControl.Subversion.Tests")]

Modified: main/src/addins/VersionControl/MonoDevelop.VersionControl.Subversion.Unix/MonoDevelop.VersionControl.Subversion.Unix/LibApr.cs
===================================================================
@@ -4,7 +4,7 @@
 
 namespace MonoDevelop.VersionControl.Subversion.Unix
 {
-	public abstract class LibApr
+	abstract class LibApr
 	{
 		public static readonly int APR_OS_DEFAULT = 0xFFF;
 		public static readonly int APR_WRITE = 2;
@@ -31,7 +31,7 @@ public static LibApr GetLib (int ver)
 			}
 		}
 		
-		public LibApr ()
+		protected LibApr ()
 		{
 			initialize ();
 		}
@@ -64,9 +64,9 @@ public IntPtr pcalloc (IntPtr pool, object structure)
 		public const int APR_OS_START_USEERR = APR_OS_START_USERERR;
 	}
 
-	public sealed class LibApr0: LibApr
+	sealed class LibApr0: LibApr
 	{
-		private const string aprlib = "libapr-0.so.0";
+		const string aprlib = "libapr-0.so.0";
 		
 		public override int initialize() { return apr_initialize (); }
 		public override int pool_create_ex (out IntPtr pool, IntPtr parent, IntPtr abort, IntPtr allocator) { return apr_pool_create_ex(out pool, parent, abort, allocator); }
@@ -97,9 +97,9 @@ public sealed class LibApr0: LibApr
 		[DllImport(aprlib)] static extern int apr_file_close (IntPtr file); 	
 	}
 
-	public sealed class LibApr1: LibApr
+	sealed class LibApr1: LibApr
 	{
-		private const string aprlib = "libapr-1.so.0";
+		const string aprlib = "libapr-1.so.0";
 		
 		public override int initialize() { return apr_initialize (); }
 		public override int pool_create_ex (out IntPtr pool, IntPtr parent, IntPtr abort, IntPtr allocator) { return apr_pool_create_ex(out pool, parent, abort, allocator); }

Modified: main/src/addins/VersionControl/MonoDevelop.VersionControl.Subversion.Unix/MonoDevelop.VersionControl.Subversion.Unix/LibSvnClient.cs
===================================================================
@@ -12,8 +12,8 @@
 using size_t = System.Int32;
 
 namespace MonoDevelop.VersionControl.Subversion.Unix {
-	public abstract class LibSvnClient {
-		public LibSvnClient ()
+	abstract class LibSvnClient {
+		protected LibSvnClient ()
 		{
 			client_version ();
 		}

Modified: main/src/addins/VersionControl/MonoDevelop.VersionControl.Subversion.Unix/MonoDevelop.VersionControl.Subversion.Unix/LibSvnClient0.cs
===================================================================
@@ -32,8 +32,8 @@
 
 namespace MonoDevelop.VersionControl.Subversion.Unix {
 	
-	public sealed class LibSvnClient0 : LibSvnClient {
-		private const string svnclientlib = "libsvn_client-1.so.0";
+	sealed class LibSvnClient0 : LibSvnClient {
+		const string svnclientlib = "libsvn_client-1.so.0";
 
 		public override IntPtr client_root_url_from_path (ref IntPtr url, string path_or_url, IntPtr ctx, IntPtr pool)
 		{

Modified: main/src/addins/VersionControl/MonoDevelop.VersionControl.Subversion.Unix/MonoDevelop.VersionControl.Subversion.Unix/LibSvnClient1.cs
===================================================================
@@ -32,8 +32,8 @@
 
 namespace MonoDevelop.VersionControl.Subversion.Unix {
 	
-	public sealed class LibSvnClient1 : LibSvnClient {
-		private const string svnclientlib = "libsvn_client-1.so.1";
+	sealed class LibSvnClient1 : LibSvnClient {
+		const string svnclientlib = "libsvn_client-1.so.1";
 		
 		public override IntPtr client_root_url_from_path (ref IntPtr url, string path_or_url, IntPtr ctx, IntPtr pool)
 		{

Modified: main/src/addins/VersionControl/MonoDevelop.VersionControl.Subversion.Unix/MonoDevelop.VersionControl.Subversion.Unix/SvnClient.cs
===================================================================
@@ -15,7 +15,7 @@
 
 namespace MonoDevelop.VersionControl.Subversion.Unix
 {
-	public sealed class SvnClient : SubversionVersionControl
+	sealed class SvnClient : SubversionVersionControl
 	{
 		static LibApr apr;
 		static readonly Lazy<bool> isInstalled;
@@ -201,7 +201,7 @@ public override string GetDirectoryDotSvn (FilePath path)
 		}
 	}
 
-	public sealed class UnixSvnBackend : SubversionBackend
+	sealed class UnixSvnBackend : SubversionBackend
 	{
 		protected static LibApr apr {
 			get {
@@ -1527,7 +1527,7 @@ void CollectorFunc (IntPtr baton, IntPtr path, IntPtr statusPtr)
 			}
 		}
 		
-		private class LogCollector
+		class LogCollector
 		{
 			static readonly DateTime Epoch = new DateTime (1970, 1, 1);
 			

Modified: main/src/addins/VersionControl/MonoDevelop.VersionControl.Subversion/AssemblyInfo.cs
===================================================================
@@ -9,3 +9,5 @@
 [assembly: AssemblyVersion ("2.6")]
 [assembly: AssemblyCopyright ("LGPL")]
 [assembly: InternalsVisibleTo ("MonoDevelop.VersionControl.Subversion.Tests")]
+[assembly: InternalsVisibleTo ("MonoDevelop.VersionControl.Subversion.Unix")]
+[assembly: InternalsVisibleTo ("VersionControl.Subversion.Win32")]

Modified: main/src/addins/VersionControl/MonoDevelop.VersionControl.Subversion/MonoDevelop.VersionControl.Subversion.Gui/ClientCertificateDialog.cs
===================================================================
@@ -5,7 +5,7 @@
 
 namespace MonoDevelop.VersionControl.Subversion.Gui
 {
-	public partial class ClientCertificateDialog : Gtk.Dialog
+	partial class ClientCertificateDialog : Gtk.Dialog
 	{
 		public ClientCertificateDialog (string realm, bool maySave)
 		{

Modified: main/src/addins/VersionControl/MonoDevelop.VersionControl.Subversion/MonoDevelop.VersionControl.Subversion.Gui/ClientCertificatePasswordDialog.cs
===================================================================
@@ -5,7 +5,7 @@
 
 namespace MonoDevelop.VersionControl.Subversion.Gui
 {
-	public partial class ClientCertificatePasswordDialog : Gtk.Dialog
+	partial class ClientCertificatePasswordDialog : Gtk.Dialog
 	{
 		public ClientCertificatePasswordDialog (string realm, bool maySave)
 		{

Modified: main/src/addins/VersionControl/MonoDevelop.VersionControl.Subversion/MonoDevelop.VersionControl.Subversion.Gui/SslServerTrustDialog.cs
===================================================================
@@ -5,7 +5,7 @@
 
 namespace MonoDevelop.VersionControl.Subversion.Gui
 {
-	public partial class SslServerTrustDialog : Gtk.Dialog
+	partial class SslServerTrustDialog : Gtk.Dialog
 	{
 		SslFailure failures;
 		

Modified: main/src/addins/VersionControl/MonoDevelop.VersionControl.Subversion/MonoDevelop.VersionControl.Subversion.Gui/UserPasswordDialog.cs
===================================================================
@@ -5,7 +5,7 @@
 
 namespace MonoDevelop.VersionControl.Subversion.Gui
 {
-	public partial class UserPasswordDialog : Gtk.Dialog
+	partial class UserPasswordDialog : Gtk.Dialog
 	{
 		public UserPasswordDialog (string user, string realm, bool mayRemember, bool showPassword)
 		{

Modified: main/src/addins/VersionControl/MonoDevelop.VersionControl.Subversion/gtk-gui/MonoDevelop.VersionControl.Subversion.Gui.ClientCertificateDialog.cs
===================================================================
@@ -2,7 +2,7 @@
 // This file has been generated by the GUI designer. Do not modify.
 namespace MonoDevelop.VersionControl.Subversion.Gui
 {
-	public partial class ClientCertificateDialog
+	internal partial class ClientCertificateDialog
 	{
 		private global::Gtk.VBox vbox2;
 		private global::Gtk.Label label1;

Modified: main/src/addins/VersionControl/MonoDevelop.VersionControl.Subversion/gtk-gui/MonoDevelop.VersionControl.Subversion.Gui.ClientCertificatePasswordDialog.cs
===================================================================
@@ -2,7 +2,7 @@
 // This file has been generated by the GUI designer. Do not modify.
 namespace MonoDevelop.VersionControl.Subversion.Gui
 {
-	public partial class ClientCertificatePasswordDialog
+	internal partial class ClientCertificatePasswordDialog
 	{
 		private global::Gtk.VBox vbox2;
 		private global::Gtk.Label label1;

Modified: main/src/addins/VersionControl/MonoDevelop.VersionControl.Subversion/gtk-gui/MonoDevelop.VersionControl.Subversion.Gui.SslServerTrustDialog.cs
===================================================================
@@ -2,7 +2,7 @@
 // This file has been generated by the GUI designer. Do not modify.
 namespace MonoDevelop.VersionControl.Subversion.Gui
 {
-	public partial class SslServerTrustDialog
+	internal partial class SslServerTrustDialog
 	{
 		private global::Gtk.HBox hbox1;
 		private global::Gtk.VBox vbox2;

Modified: main/src/addins/VersionControl/MonoDevelop.VersionControl.Subversion/gtk-gui/MonoDevelop.VersionControl.Subversion.Gui.UserPasswordDialog.cs
===================================================================
@@ -2,7 +2,7 @@
 // This file has been generated by the GUI designer. Do not modify.
 namespace MonoDevelop.VersionControl.Subversion.Gui
 {
-	public partial class UserPasswordDialog
+	internal partial class UserPasswordDialog
 	{
 		private global::Gtk.VBox vbox2;
 		private global::Gtk.Label label4;

Modified: main/src/addins/VersionControl/MonoDevelop.VersionControl.Subversion/gtk-gui/gui.stetic
===================================================================
@@ -14,6 +14,7 @@
     <property name="MemberName" />
     <property name="Visible">False</property>
     <property name="Events">ButtonPressMask</property>
+    <property name="GeneratePublic">False</property>
     <property name="Title" translatable="yes">Subversion</property>
     <property name="Modal">True</property>
     <property name="Resizable">False</property>
@@ -224,6 +225,7 @@
     <property name="MemberName" />
     <property name="Visible">False</property>
     <property name="Events">ButtonPressMask</property>
+    <property name="GeneratePublic">False</property>
     <property name="Title" translatable="yes">Repository Certified by an Unknown Authority</property>
     <property name="Modal">True</property>
     <property name="Buttons">2</property>
@@ -711,6 +713,7 @@
     <property name="MemberName" />
     <property name="Visible">False</property>
     <property name="Events">ButtonPressMask</property>
+    <property name="GeneratePublic">False</property>
     <property name="Title" translatable="yes">Client Certificate Required</property>
     <property name="Buttons">2</property>
     <property name="HelpButton">False</property>
@@ -784,6 +787,7 @@
                 <child>
                   <widget class="MonoDevelop.Components.FileEntry" id="fileentry">
                     <property name="MemberName" />
+                    <property name="DisplayAsRelativePath">False</property>
                   </widget>
                   <packing>
                     <property name="Position">1</property>
@@ -872,6 +876,7 @@
     <property name="MemberName" />
     <property name="Visible">False</property>
     <property name="Events">ButtonPressMask</property>
+    <property name="GeneratePublic">False</property>
     <property name="Title" translatable="yes">Password for client certificate</property>
     <property name="Buttons">2</property>
     <property name="HelpButton">False</property>

Modified: main/src/addins/VersionControl/Subversion.Win32/Properties/AssemblyInfo.cs
===================================================================
@@ -4,6 +4,9 @@
 // General Information about an assembly is controlled through the following 
 // set of attributes. Change these attribute values to modify the information
 // associated with an assembly.
+using System.Runtime.CompilerServices;
+
+
 [assembly: AssemblyTitle ("SubversionAddinWindows")]
 [assembly: AssemblyDescription ("")]
 [assembly: AssemblyConfiguration ("")]
@@ -33,3 +36,5 @@
 // [assembly: AssemblyVersion("1.0.*")]
 [assembly: AssemblyVersion ("1.0.0.0")]
 [assembly: AssemblyFileVersion ("1.0.0.0")]
+
+[assembly: InternalsVisibleTo ("VersionControl.Subversion.Win32.Tests")]


Modified: main/src/addins/VersionControl/Subversion.Win32/SvnSharpClient.cs
===================================================================
@@ -13,7 +13,7 @@
 
 namespace SubversionAddinWindows
 {
-	public sealed class SvnSharpClient: SubversionVersionControl
+	sealed class SvnSharpClient: SubversionVersionControl
 	{
 		static bool errorShown;
 		static readonly bool installError;
@@ -75,7 +75,7 @@ public override string GetDirectoryDotSvn (FilePath path)
 		}
 	}
 
-	public sealed class SvnSharpBackend: SubversionBackend
+	sealed class SvnSharpBackend: SubversionBackend
 	{
 		SvnClient client;
 		IProgressMonitor updateMonitor;



_______________________________________________
Mono-patches maillist  -  [email protected]
http://lists.ximian.com/mailman/listinfo/mono-patches
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.