Branch: refs/heads/master
Home: https://github.com/mono/monodevelop
Compare: https://github.com/mono/monodevelop/compare/5fddca2c7b1f...8c24502e8d4f
Commit: ebd0ce8b4a8e390cf6a2409887f0d867eb9ba408
Author: Therzok <[email protected]> (Therzok)
Date: 2013-11-01 03:43:26 GMT
URL: https://github.com/mono/monodevelop/commit/ebd0ce8b4a8e390cf6a2409887f0d867eb9ba408
Replace reference equality with value equality for valuetypes.
Changed paths:
M main/src/core/Mono.Texteditor/Mono.TextEditor.Vi/ViKeyNotation.cs
Modified: main/src/core/Mono.Texteditor/Mono.TextEditor.Vi/ViKeyNotation.cs
===================================================================
@@ -86,7 +86,7 @@ public override bool Equals (object obj)
{
if (obj == null)
return false;
- if (ReferenceEquals (this, obj))
+ if (object.Equals (this, obj))
return true;
if (!(obj is ViKey))
return false;
Commit: e70f879f9c7427803a3ee25df61b1c9e139434a4
Author: Therzok <[email protected]> (Therzok)
Date: 2013-11-01 03:56:20 GMT
URL: https://github.com/mono/monodevelop/commit/e70f879f9c7427803a3ee25df61b1c9e139434a4
[GtkCore] Fix a conditional which never passed.
Changed paths:
M main/src/addins/MonoDevelop.GtkCore/MonoDevelop.GtkCore/WidgetParser.cs
Modified: main/src/addins/MonoDevelop.GtkCore/MonoDevelop.GtkCore/WidgetParser.cs
===================================================================
@@ -126,7 +126,7 @@ public string GetCategory (IEntity decoration)
var pargs = at.PositionalArguments;
if (pargs != null && pargs.Count > 0) {
var val = pargs[0] as ConstantResolveResult;
- if (val is string)
+ if (val != null && val.ConstantValue is string)
return val.ConstantValue.ToString ();
}
}
Commit: c2123cc6c039fb2cb5ef16f6a702d3b91d6e6653
Author: Therzok <[email protected]> (Therzok)
Date: 2013-11-01 04:28:29 GMT
URL: https://github.com/mono/monodevelop/commit/c2123cc6c039fb2cb5ef16f6a702d3b91d6e6653
Fix infinite loops.
Changed paths:
M main/src/addins/MacPlatform/MacInterop/Carbon.cs
M main/src/addins/MonoDevelop.DesignerSupport/MonoDevelop.DesignerSupport/CustomDescriptor.cs
M main/src/core/MonoDevelop.Core/MonoDevelop.Core/LoggingService.cs
Modified: main/src/addins/MacPlatform/MacInterop/Carbon.cs
===================================================================
@@ -570,7 +570,7 @@ struct OSType {
int value;
public int Value {
- get { return Value; }
+ get { return value; }
}
public OSType (int value)
Modified: main/src/addins/MonoDevelop.DesignerSupport/MonoDevelop.DesignerSupport/CustomDescriptor.cs
===================================================================
@@ -165,7 +165,7 @@ public override void AddValueChanged (object component, EventHandler handler)
public override void RemoveValueChanged (object component, EventHandler handler)
{
- RemoveValueChanged (component, handler);
+ prop.RemoveValueChanged (component, handler);
}
public override object GetValue (object component)
Modified: main/src/core/MonoDevelop.Core/MonoDevelop.Core/LoggingService.cs
===================================================================
@@ -160,7 +160,7 @@ internal static void ReportUnhandledException (Exception ex, bool willShutDown)
internal static void ReportUnhandledException (Exception ex, bool willShutDown, bool silently)
{
- ReportUnhandledException (ex, willShutDown, silently);
+ ReportUnhandledException (ex, willShutDown, silently, null);
}
internal static void ReportUnhandledException (Exception ex, bool willShutDown, bool silently, string tag)
Commit: 8c24502e8d4f6b1bd1daa78ff6d8e7de49b92c88
Author: Ungureanu Marius <[email protected]> (Therzok)
Date: 2013-11-01 04:38:33 GMT
URL: https://github.com/mono/monodevelop/commit/8c24502e8d4f6b1bd1daa78ff6d8e7de49b92c88
Merge pull request #426 from mono/codeIssueFixes
Functionality and code issues fixes
Changed paths:
M main/src/addins/MacPlatform/MacInterop/Carbon.cs
M main/src/addins/MonoDevelop.DesignerSupport/MonoDevelop.DesignerSupport/CustomDescriptor.cs
M main/src/addins/MonoDevelop.GtkCore/MonoDevelop.GtkCore/WidgetParser.cs
M main/src/core/Mono.Texteditor/Mono.TextEditor.Vi/ViKeyNotation.cs
M main/src/core/MonoDevelop.Core/MonoDevelop.Core/LoggingService.cs
Modified: main/src/addins/MacPlatform/MacInterop/Carbon.cs
===================================================================
@@ -570,7 +570,7 @@ struct OSType {
int value;
public int Value {
- get { return Value; }
+ get { return value; }
}
public OSType (int value)
Modified: main/src/addins/MonoDevelop.DesignerSupport/MonoDevelop.DesignerSupport/CustomDescriptor.cs
===================================================================
@@ -165,7 +165,7 @@ public override void AddValueChanged (object component, EventHandler handler)
public override void RemoveValueChanged (object component, EventHandler handler)
{
- RemoveValueChanged (component, handler);
+ prop.RemoveValueChanged (component, handler);
}
public override object GetValue (object component)
Modified: main/src/addins/MonoDevelop.GtkCore/MonoDevelop.GtkCore/WidgetParser.cs
===================================================================
@@ -126,7 +126,7 @@ public string GetCategory (IEntity decoration)
var pargs = at.PositionalArguments;
if (pargs != null && pargs.Count > 0) {
var val = pargs[0] as ConstantResolveResult;
- if (val is string)
+ if (val != null && val.ConstantValue is string)
return val.ConstantValue.ToString ();
}
}
Modified: main/src/core/Mono.Texteditor/Mono.TextEditor.Vi/ViKeyNotation.cs
===================================================================
@@ -86,7 +86,7 @@ public override bool Equals (object obj)
{
if (obj == null)
return false;
- if (ReferenceEquals (this, obj))
+ if (object.Equals (this, obj))
return true;
if (!(obj is ViKey))
return false;
Modified: main/src/core/MonoDevelop.Core/MonoDevelop.Core/LoggingService.cs
===================================================================
@@ -160,7 +160,7 @@ internal static void ReportUnhandledException (Exception ex, bool willShutDown)
internal static void ReportUnhandledException (Exception ex, bool willShutDown, bool silently)
{
- ReportUnhandledException (ex, willShutDown, silently);
+ ReportUnhandledException (ex, willShutDown, silently, null);
}
internal static void ReportUnhandledException (Exception ex, bool willShutDown, bool silently, string tag)
_______________________________________________
Mono-patches maillist - [email protected]
http://lists.ximian.com/mailman/listinfo/mono-patches
lmpx.com only provides a reader for public news (NNTP) servers. It is not
affiliated with the servers or forums shown here and is not responsible for
the content of articles, which is written by their respective authors.